Differential D59503

p9fs: fix use-after-free when p9fs_vget_common fails
Needs ReviewPublic
Actions

Authored by njain15_protonmail.com on Tue, Sep 8, 5:37 AM.

Tags

None

Referenced Files

	F171044404: D59503.id.diff
	Tue, Sep 8, 9:10 AM

Subscribers

Details

Reviewers

Summary

Some callers of p9fs_vget_common (ex. p9fs_lookup) clunk the new fid as part of their error cleanup procedure. However, during certain points of the vnode creation, failure already reclaims the node. This causes double clunking of the VFID, which can lead to a panic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

njain15_protonmail.com created this revision.Tue, Sep 8, 5:37 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 8, 5:37 AM

njain15_protonmail.com requested review of this revision.Tue, Sep 8, 5:37 AM

njain15_protonmail.com added a child revision: D58635: p9fs: add socket transport.

Revision Contents
Changeset List

Path

Size

sys/

fs/

p9fs/

1 line

8 lines

2 lines

Diff 186196

sys/fs/p9fs/p9fs.h

Loading...

sys/fs/p9fs/p9fs_subr.c

Loading...

sys/fs/p9fs/p9fs_vfsops.c

Loading...