swapongeom: destroy consumer in case swaponsomething failed

[kib]

Summary

Fixes:  aa42e4984997c9d3aa5d30534bdaf760e613e97b
Reported by:    olivier

[markj]

Do we also need to call VOP_CLOSE in the error path in swaponvp()?

[kib]

In D51636#1179353, @markj wrote:

Do we also need to call VOP_CLOSE in the error path in swaponvp()?

I thought it is done by sys_swapon(), but apparently not.

[kib]

Close the vnode on failure.

[olivier]

I have still the same problem (did a full buildworld + buildkernel reinstall):

$ truncate -s 1000 swapfile
$ echo 'md99    none    swap    sw,file=swapfile  0       0' > fstab.out
$ sudo swapon -F fstab.out -a
swapon: /dev/md99: NSWAPDEV limit reached
$ sudo mdconfig -l
md99
$ sudo mdconfig -d -u 99
mdconfig: ioctl(/dev/mdctl): Device busy

[kib]

Also roll back g_access()

[olivier]

still same error with this diff #3.

[kib]

In D51636#1179449, @olivier wrote:

still same error with this diff #3.

Are you sure? I checked that with the diff with g_access(-1,...) I can destroy a small md after failed swapon.

[olivier]

ooops yes, you’ve right! Don’t know how I’ve failed to correctly test that.