pam_krb5: fix the GCC build
ClosedPublic
Actions

Authored by ivy on Jul 27 2025, 5:16 PM.

Details

Reviewers

cy
des
emaste

Group Reviewers

krb5

Commits

rG62473ce8ccba: pam_krb5: fix the GCC build

Summary

GCC doesn't recognise
-Wno-error=incompatible-pointer-types-discards-qualifiers.

Remove it and just fix the error instead: our pam_message does not have
a const msg member.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Jul 27 2025, 5:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2025, 5:16 PM

ivy requested review of this revision.Jul 27 2025, 5:16 PM

Harbormaster completed remote builds in B65775: Diff 159243.Jul 27 2025, 5:16 PM

ivy added a reviewer: krb5.Jul 27 2025, 5:43 PM

The real question is, why are we using this module instead of our own?

according to https://lists.freebsd.org/archives/dev-commits-src-all/2025-May/055576.html,

The reason for this import is to provide an MIT KRB5 compatible
pam_krb5 PAM module. The existing pam_krb5 in FreeBS only works
with Heimdal.

We can sort out whether this code should exist separately; this change seems reasonable given that it does currently exist in the tree.

This revision is now accepted and ready to land.Jul 31 2025, 10:13 PM

cy accepted this revision.Aug 1 2025, 4:11 AM

Closed by commit rG62473ce8ccba: pam_krb5: fix the GCC build (authored by ivy). · Explain WhyAug 1 2025, 2:17 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG62473ce8ccba: pam_krb5: fix the GCC build.

Revision Contents
Changeset List

Path

Size

contrib/

pam-krb5/

module/

prompting.c

2 lines

lib/

libpam/

modules/

pam_krb5/

Makefile

1 line

Diff 159561

View Options

contrib/pam-krb5/module/prompting.c