Page MenuHomeFreeBSD
Differential D51166

cam/xpt: improve comment on xpt_path_inq
ClosedPublic
Actions

Authored by imp on Jul 5 2025, 6:15 PM.
Tags
None
Referenced Files
F132646482: D51166.id158132.diff
Sat, Oct 18, 5:38 PM
F132578785: D51166.id158132.diff
Sat, Oct 18, 3:25 AM
Unknown Object (File)
Tue, Oct 14, 2:05 AM
Unknown Object (File)
Mon, Oct 13, 12:33 PM
Unknown Object (File)
Mon, Oct 13, 12:33 PM
Unknown Object (File)
Sun, Oct 12, 11:58 PM
Unknown Object (File)
Tue, Sep 23, 4:53 PM
Unknown Object (File)
Sep 15 2025, 7:47 PM
View All 30 Files
Subscribers
None

Details

Reviewers
jhb
ken
mav
Group Reviewers
cam
Commits
rG034b3515ea27: cam/xpt: improve comment on xpt_path_inq
Summary

Fix a comment about bzero maybe unnecessary. It can sometimes be
redunant, but a common usage pattern puts the ccb_pathinq structure on
the stack since it's small and for that scenario, it's required. It's
reundant for the few places the ccb is allocated, and in those cases it
does no harm.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 5 2025, 6:15 PM
Herald added a reviewer: cam. · View Herald TranscriptJul 5 2025, 6:15 PM
imp requested review of this revision.Jul 5 2025, 6:15 PM
Harbormaster completed remote builds in B65227: Diff 158022.Jul 5 2025, 6:15 PM
imp added a child revision: D51167: xpt_path_inq: Use CAM_PRIORITY_NONE.Jul 5 2025, 6:15 PM
jhb accepted this revision.Jul 7 2025, 5:00 PM
jhb added inline comments.
sys/cam/cam_xpt.h
149

I would maybe just drop the last sentence as I think the comment about (dynamically) allocated vs on-stack is sufficient.

This revision is now accepted and ready to land.Jul 7 2025, 5:00 PM
imp added inline comments.Jul 7 2025, 8:05 PM
sys/cam/cam_xpt.h
149

Sure. That makes sense... I tend to over do it in CAM comments because the code isn't always the most straight forward in spots.

Closed by commit rG034b3515ea27: cam/xpt: improve comment on xpt_path_inq (authored by imp). · Explain WhyJul 7 2025, 11:19 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG034b3515ea27: cam/xpt: improve comment on xpt_path_inq.

Revision Contents
Changeset List

PathSize
sys/
cam/
4 lines

Diff 158132

View Options

sys/cam/cam_xpt.h

Loading...