cam: In scsi_scan_bus, fix an error case

[imp]

Summary

If we can't allocate the new path when loopoing over the target range,
then we have to free the scan_info->cpi CCB, not the work_ccb. This was
accidentally correct for the first iteration (because work_ccb ==
scan_info->cpi), but incorrect after that since we'll be freeing the CCB
for XPT_SCAN_LUN for the prior LUN we kicked off. Reorder the free so we
free it before we free scan_info so the pointer is still valid.

I do not have a test case for this since it requires that we fail in the
second or later iteration of the loop due to low memory, and only
fuzzing would catch that.

Sponsored by: Netflix

[jhb]

sys/cam/scsi/scsi_xpt.c

2041

I think the "it" here is confusing as on my first reading I mapped it back to "work_ccb" since that was mentioned first. But also, I wonder if you can just drop this comment entirely. The next block below that handle allocation failure for work_ccb is identical to the new code, so your fix is making the code more consistent and thus probably obvious to the reader.

[imp]

sys/cam/scsi/scsi_xpt.c

2041

OK. Maybe you're right, so I'll just drop this comment.