Page MenuHomeFreeBSD
Differential D51150

Jail sysctls: deprecated a generic sysctl in favour of allow-flags
ClosedPublic
Actions

Authored by netchild on Jul 3 2025, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 18, 7:20 AM
Unknown Object (File)
Sat, Apr 18, 5:46 AM
Unknown Object (File)
Sat, Apr 11, 2:40 PM
Unknown Object (File)
Sat, Apr 11, 10:05 AM
Unknown Object (File)
Sun, Apr 5, 1:42 PM
Unknown Object (File)
Sun, Apr 5, 6:56 AM
Unknown Object (File)
Tue, Mar 31, 4:32 PM
Unknown Object (File)
Mar 19 2026, 5:40 AM
View All 31 Files
Subscribers
emaste
imp
jamie
olce

Details

Reviewers
None
Group Reviewers
Jails
Commits
rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags
Summary
  • add the missing sysctl to the deprecated list
  • add a comment to not add new generic sysctls and point to SYSCTL_JAIL_PARAM instead

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

netchild created this revision.Jul 3 2025, 3:44 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2025, 3:44 PM
netchild requested review of this revision.Jul 3 2025, 3:44 PM
jamie accepted this revision as: Jails.Jul 7 2025, 4:39 PM
jamie added a subscriber: jamie.

Yes, anything that makes these things more obviously deprecated is better.

emaste added a subscriber: emaste.Tue, Mar 31, 3:28 PM

Is this waiting on anything before commit?

netchild added a comment.Tue, Mar 31, 4:32 PM

Yes, it waits for me to remember that this is not committed...

netchild abandoned this revision.Tue, Mar 31, 4:39 PM

I was wrong. It is committed. It just needs to be closed here. I do not see a way to close. Maybe I'm blind... the only thing I found was abandoning this revision.

emaste added a comment.Tue, Mar 31, 4:42 PM

I don't see it committed?

9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5015) SYSCTL_PROC(_security_jail, OID_AUTO, mlock_allowed,
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5016)     CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_MPSAFE,
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5017)     NULL, PR_ALLOW_MLOCK, sysctl_jail_default_allow, "I",
9fd978680db649 (Baptiste Daroussin      2024-01-04 15:09:44 +0100 5018)     "Processes in jail can lock/unlock physical pages in memory");
netchild reclaimed this revision.Tue, Mar 31, 5:19 PM

Very strange. First "patch" told me it is already applied (it was a pristine src tree). Now I do a git diff and it is showing up. Pffft.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Mar 31, 5:24 PM
Closed by commit rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags (authored by netchild). · Explain Why
This revision was automatically updated to reflect the committed changes.
netchild added a commit: rG6087050ef52c: Jail sysctls: deprecate generic sysctls in favour of allow-flags.
Herald added a subscriber: olce. · View Herald TranscriptTue, Mar 31, 5:24 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines

Diff 174683

View Options

sys/kern/kern_jail.c

Loading...