Page MenuHomeFreeBSD
Differential D50935

libc: Add fscandir(), fscandir_b(), scandirat_b().
ClosedPublic
Actions

Authored by des on Jun 19 2025, 10:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 5, 12:23 PM
Unknown Object (File)
Thu, Mar 5, 12:05 PM
Unknown Object (File)
Thu, Mar 5, 12:05 PM
Unknown Object (File)
Mon, Mar 2, 9:22 PM
Unknown Object (File)
Fri, Feb 27, 12:55 PM
Unknown Object (File)
Tue, Feb 24, 6:13 PM
Unknown Object (File)
Tue, Feb 24, 10:46 AM
Unknown Object (File)
Tue, Feb 24, 10:45 AM
View All 63 Files
Subscribers
imp
markj
ziaee

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG8b2062419c33: libc: Add fscandir(), fscandir_b(), scandirat_b().
rGdeeebfdecab5: libc: Add fscandir(), fscandir_b(), scandirat_b().
Summary

While here, clean up scandir() a bit and improve the documentation.

MFC after: never
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Jun 19 2025, 10:14 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJun 19 2025, 10:14 AM
des requested review of this revision.Jun 19 2025, 10:14 AM
Harbormaster completed remote builds in B64978: Diff 157304.Jun 19 2025, 10:14 AM
des added a child revision: D50936: diff: Detect loops when diffing directories..Jun 19 2025, 12:48 PM
des added a reviewer: Klara.
markj accepted this revision as: markj.Jun 19 2025, 1:42 PM
markj added a subscriber: markj.
markj added inline comments.
lib/libc/gen/scandir.3
239

scandirat() is also in glibc--should it be referred to as a GNU extension as well?

lib/libc/gen/scandir.c
181

A bit off-topic for the review, but I wonder why scandir() isn't careful to preserve errno. Is that a bug?

This revision is now accepted and ready to land.Jun 19 2025, 1:42 PM
des updated this revision to Diff 157319.Jun 19 2025, 4:11 PM

review feedback, more tests and cleanup

This revision now requires review to proceed.Jun 19 2025, 4:11 PM
Harbormaster completed remote builds in B64986: Diff 157319.Jun 19 2025, 4:11 PM
des edited the summary of this revision. (Show Details)Jun 19 2025, 4:12 PM
des marked 2 inline comments as done.Jun 19 2025, 4:14 PM
markj accepted this revision as: markj.Jun 19 2025, 7:22 PM
This revision is now accepted and ready to land.Jun 19 2025, 7:22 PM
Closed by commit rGdeeebfdecab5: libc: Add fscandir(), fscandir_b(), scandirat_b(). (authored by des). · Explain WhyJun 20 2025, 11:11 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGdeeebfdecab5: libc: Add fscandir(), fscandir_b(), scandirat_b()..
des added a commit: rG8b2062419c33: libc: Add fscandir(), fscandir_b(), scandirat_b()..Thu, Feb 5, 3:27 PM

Revision Contents
Changeset List

PathSize
include/
13 lines
lib/
libc/
gen/
5 lines
3 lines
94 lines
101 lines
tests/
gen/
6 lines
118 lines
112 lines

Diff 157348

View Options

include/dirent.h

Loading...
View Options

lib/libc/gen/Makefile.inc

Loading...
View Options

lib/libc/gen/Symbol.map

Loading...
View Options

lib/libc/gen/scandir.3

Loading...
View Options

lib/libc/gen/scandir.c

Loading...
View Options

lib/libc/tests/gen/Makefile

Loading...
View Options

lib/libc/tests/gen/scandir_blocks_test.c

Loading...
View Options

lib/libc/tests/gen/scandir_test.c

Loading...