Differential D50890

tcp: remove CTLFLAG_NEEDGIANT from sysctl(9) handlers related to timers
ClosedPublic
Actions

Authored by glebius on Jun 16 2025, 11:52 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rGfaa6aa7723aa: tcp: remove CTLFLAG_NEEDGIANT from sysctl(9) handlers related to timers

Summary

They all just modify a global word sized variable via
sysctl_msec_to_ticks(), which is wrapper around sysctl_handle_int().
Note, they all were marked with CTLFLAG_NEEDGIANT merely because it was
not obvious whether they are mpsafe or not.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64924
Build 61807: arc lint + arc unit

Event Timeline

glebius created this revision.Jun 16 2025, 11:52 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJun 16 2025, 11:52 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jun 16 2025, 11:52 PM

Harbormaster completed remote builds in B64924: Diff 157149.Jun 16 2025, 11:52 PM

glebius added a child revision: D50891: tcp: provide sysctl for the maximum retransmission timeout.Jun 16 2025, 11:52 PM

tuexen accepted this revision.Jun 17 2025, 4:10 AM

This revision is now accepted and ready to land.Jun 17 2025, 4:10 AM

Closed by commit rGfaa6aa7723aa: tcp: remove CTLFLAG_NEEDGIANT from sysctl(9) handlers related to timers (authored by glebius). · Explain WhyJun 17 2025, 3:54 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGfaa6aa7723aa: tcp: remove CTLFLAG_NEEDGIANT from sysctl(9) handlers related to timers.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_timer.c

33 lines

Diff 157149

View Options

tcp: remove CTLFLAG_NEEDGIANT from sysctl(9) handlers related to timersClosedPublicActions