Page MenuHomeFreeBSD

EHCI: Make core reset and port speed reading more generic.
ClosedPublic

Authored by mmel on Jan 27 2016, 12:33 PM.
Tags
None
Referenced Files
F101301516: D5088.diff
Sun, Oct 27, 11:18 AM
Unknown Object (File)
Sat, Oct 12, 6:58 AM
Unknown Object (File)
Fri, Oct 4, 4:00 AM
Unknown Object (File)
Thu, Oct 3, 5:55 PM
Unknown Object (File)
Thu, Oct 3, 4:01 PM
Unknown Object (File)
Tue, Oct 1, 7:02 PM
Unknown Object (File)
Tue, Oct 1, 5:44 PM
Unknown Object (File)
Sep 19 2024, 1:37 AM

Details

Summary

Use driver settable callbacks for handling of:

  • core post reset
  • reading actual port speed

Typically, OTG enabled EHCI cores wants setting of USBMODE register,
but this register is not defined in EHCI specification and different
cores can have it on different offset.

Also, for cores with TT extension, actual port speed must be determinable.
But again, EHCI specification not covers this so this patch provides
function for two most common variant of speed bits layout.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mmel retitled this revision from to EHCI: Make core reset and port speed reading more generic..
mmel updated this object.
mmel edited the test plan for this revision. (Show Details)
mmel added a reviewer: hselasky.
mmel set the repository for this revision to rS FreeBSD src repository - subversion.
mmel added subscribers: thompsa, alfred.

Looks good. I'll get some people to test it.

hselasky edited edge metadata.

Do you want me to commit the patch?

This revision is now accepted and ready to land.Jan 28 2016, 1:55 PM

Nope, i will do it (and i must request to rename my phabricator account).
Thanks for review.

This revision was automatically updated to reflect the committed changes.