Page MenuHomeFreeBSD
Differential D50776

devel/git: Rename HTMLDOCS option into canonical DOCS option
ClosedPublic
Actions

Authored by michaelo on Tue, Jun 10, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 5:58 AM
Unknown Object (File)
Mon, Jun 16, 3:35 AM
Unknown Object (File)
Sun, Jun 15, 11:39 AM
Unknown Object (File)
Sun, Jun 15, 3:10 AM
Unknown Object (File)
Sat, Jun 14, 7:17 PM
Unknown Object (File)
Tue, Jun 10, 2:33 PM
Subscribers
None

Details

Reviewers
jrm
otis
garga
Commits
R11:a4ac5a4c35cd: devel/git: Rename HTMLDOCS option into canonical DOCS option
Summary

Let users globally decide whether they want to have these docs in their ports.

This change has also discovered a bug where parts of the documentation where
not installed at all.

Approved by: jrm (mentor), otis (mentor), garga (maintainer)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Tue, Jun 10, 12:49 PM
michaelo created this revision.
Harbormaster completed remote builds in B64744: Diff 156781.Tue, Jun 10, 12:49 PM
otis accepted this revision.Tue, Jun 10, 1:02 PM

LGTM, let's also @garga to speak up.

This revision is now accepted and ready to land.Tue, Jun 10, 1:02 PM
garga requested changes to this revision.Tue, Jun 10, 2:17 PM

I'm fine with the change, after this minor tweak sorting items, it's approved by me.

Thanks!

devel/git/Makefile
74

Please keep the list alphabetically sorted

This revision now requires changes to proceed.Tue, Jun 10, 2:17 PM
michaelo updated this revision to Diff 156788.Tue, Jun 10, 2:20 PM

Sort OPTIONS, @garga please check again

Harbormaster completed remote builds in B64747: Diff 156788.Tue, Jun 10, 2:20 PM
garga accepted this revision.Tue, Jun 10, 2:27 PM
This revision is now accepted and ready to land.Tue, Jun 10, 2:27 PM
Closed by commit R11:a4ac5a4c35cd: devel/git: Rename HTMLDOCS option into canonical DOCS option (authored by michaelo). · Explain WhyTue, Jun 10, 2:32 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:a4ac5a4c35cd: devel/git: Rename HTMLDOCS option into canonical DOCS option.

Revision Contents
Changeset List

PathSize
7 lines
devel/
git/
9 lines
2022 lines

Diff 156789

View Options

UPDATING

Loading...
View Options

devel/git/Makefile

Loading...
View Options

devel/git/pkg-plist

Loading...