Page MenuHomeFreeBSD

gve: Fix timestamp invalidation for DQO queue formats
ClosedPublic

Authored by jtranoleary_google.com on Jun 4 2025, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 19, 2:21 AM
Unknown Object (File)
Tue, Sep 16, 11:52 AM
Unknown Object (File)
Tue, Sep 16, 5:33 AM
Unknown Object (File)
Sep 12 2025, 5:21 PM
Unknown Object (File)
Sep 9 2025, 7:52 PM
Unknown Object (File)
Sep 9 2025, 6:24 AM
Unknown Object (File)
Sep 7 2025, 12:35 AM
Unknown Object (File)
Aug 20 2025, 6:51 AM
Subscribers

Details

Summary

We need to invalidate timestamps when a TX queue is cleared so that the
TX timeout detection callout does not mistakenly fire for cleared
packets. When using DQO queue formats, timestamps are set on the pending
packet array whose length is not the same as the length of the
descriptor ring itself. This commit fixes logic which invalidated the
wrong number of pending packets.

Fixes: 3d2957336c7d ("gve: Add callout to detect and handle TX timeouts")
Signed-off-by: Jasper Tran O'Leary <jtranoleary@google.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 4 2025, 9:03 PM

This should have a Fixes: 3d2957336c7d ("gve: Add callout to detect and handle TX timeouts") tag, I believe.

This should have a Fixes: 3d2957336c7d ("gve: Add callout to detect and handle TX timeouts") tag, I believe.

Thank you Mark, I added this tag to the commit message using the web UI. Please let me know if anything is amiss.

This should have a Fixes: 3d2957336c7d ("gve: Add callout to detect and handle TX timeouts") tag, I believe.

Thank you Mark, I added this tag to the commit message using the web UI. Please let me know if anything is amiss.

Thanks! Please mail me a patch and I'll apply it.