Page MenuHomeFreeBSD
Differential D50377

libthr: add stable user interface for sigfastblock(2)
ClosedPublic
Actions

Authored by kib on May 16 2025, 3:12 PM.
Tags
None
Referenced Files
F133446464: D50377.diff
Sat, Oct 25, 8:58 PM
Unknown Object (File)
Sun, Oct 5, 7:16 AM
Unknown Object (File)
Sun, Oct 5, 6:14 AM
Unknown Object (File)
Sun, Oct 5, 6:11 AM
Unknown Object (File)
Sep 24 2025, 3:35 AM
Unknown Object (File)
Sep 24 2025, 1:03 AM
Unknown Object (File)
Sep 21 2025, 2:49 AM
Unknown Object (File)
Sep 20 2025, 9:25 AM
View All 48 Files
Subscribers
imp
ziaee

Details

Reviewers
emaste
markj
Commits
rG1393f9a36b9c: pthread_signals_block_np(3): document
rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.May 16 2025, 3:12 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptMay 16 2025, 3:12 PM
kib requested review of this revision.May 16 2025, 3:12 PM
markj added inline comments.May 16 2025, 3:41 PM
share/man/man3/pthread_np.3
122
share/man/man3/pthread_signals_block_np.3
53
61
62
66

I'm not sure what this sentence is saying. It sounds like it should be something like, "Synchronous signal delivery cannot be blocked in general, including with these functions."?

71
74
77
88
95

Or "aims to be as cheap as possible".

99
kib updated this revision to Diff 155567.May 16 2025, 3:50 PM
kib marked 11 inline comments as done.

Fix language mistakes in the man page.

ziaee added inline comments.May 16 2025, 8:11 PM
share/man/man3/pthread_signals_block_np.3
30

You can use the SPDX short form, it's preferred in style.9 or https://docs.freebsd.org/en/articles/license-guide/

kib added inline comments.May 17 2025, 3:48 AM
share/man/man3/pthread_signals_block_np.3
30

The FF contract has the explicit statement about the license block. It predates the SPDX tags by a decade.

Ok lets try and see.

kib updated this revision to Diff 155603.May 17 2025, 3:49 AM
markj accepted this revision.May 17 2025, 1:27 PM
markj added inline comments.
share/man/man3/pthread_signals_block_np.3
57
60
62
71
This revision is now accepted and ready to land.May 17 2025, 1:27 PM
kib marked 4 inline comments as done.May 17 2025, 5:44 PM
Closed by commit rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2) (authored by kib). · Explain WhyMay 19 2025, 6:08 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2).
kib added a commit: rG1393f9a36b9c: pthread_signals_block_np(3): document.

Revision Contents
Changeset List

PathSize
include/
2 lines
lib/
libthr/
2 lines
thread/
19 lines
share/
man/
man3/
3 lines
6 lines
103 lines

Diff 155567

View Options

include/pthread_np.h

Loading...
View Options

lib/libthr/pthread.map

Loading...
View Options

lib/libthr/thread/thr_sig.c

Loading...
View Options

share/man/man3/Makefile

Loading...
View Options

share/man/man3/pthread_np.3

Loading...
View Options

share/man/man3/pthread_signals_block_np.3

Loading...