Differential D50377

libthr: add stable user interface for sigfastblock(2)
ClosedPublic
Actions

Authored by kib on May 16 2025, 3:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 14, 9:22 PM

	Unknown Object (File)
	Sat, Jun 14, 8:37 PM

	Unknown Object (File)
	Sat, Jun 14, 7:17 PM

	Unknown Object (File)
	Sat, Jun 14, 7:17 PM

	Unknown Object (File)
	Sat, Jun 14, 7:15 PM

	Unknown Object (File)
	Sat, Jun 14, 5:02 PM

	Unknown Object (File)
	Sun, Jun 1, 4:34 AM

	Unknown Object (File)
	Sun, Jun 1, 1:19 AM

View All 18 Files

Subscribers

Details

Reviewers

emaste
markj

Commits

rG1393f9a36b9c: pthread_signals_block_np(3): document
rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.May 16 2025, 3:12 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptMay 16 2025, 3:12 PM

kib requested review of this revision.May 16 2025, 3:12 PM

markj added inline comments.May 16 2025, 3:41 PM

share/man/man3/pthread_np.3
122 ↗	(On Diff #155565)
share/man/man3/pthread_signals_block_np.3
52 ↗	(On Diff #155565)
60 ↗	(On Diff #155565)
61 ↗	(On Diff #155565)
65 ↗	(On Diff #155565)	I'm not sure what this sentence is saying. It sounds like it should be something like, "Synchronous signal delivery cannot be blocked in general, including with these functions."?
70 ↗	(On Diff #155565)
73 ↗	(On Diff #155565)
76 ↗	(On Diff #155565)
87 ↗	(On Diff #155565)
94 ↗	(On Diff #155565)	Or "aims to be as cheap as possible".
98 ↗	(On Diff #155565)

Fix language mistakes in the man page.

ziaee added inline comments.May 16 2025, 8:11 PM

share/man/man3/pthread_signals_block_np.3
30 ↗	(On Diff #155567)	You can use the SPDX short form, it's preferred in style.9 or https://docs.freebsd.org/en/articles/license-guide/

kib added inline comments.May 17 2025, 3:48 AM

share/man/man3/pthread_signals_block_np.3
30 ↗	(On Diff #155567)	The FF contract has the explicit statement about the license block. It predates the SPDX tags by a decade. Ok lets try and see.

kib updated this revision to Diff 155603.May 17 2025, 3:49 AM

markj accepted this revision.May 17 2025, 1:27 PM

markj added inline comments.

share/man/man3/pthread_signals_block_np.3
56 ↗	(On Diff #155603)
59 ↗	(On Diff #155603)
61 ↗	(On Diff #155603)
70 ↗	(On Diff #155603)

This revision is now accepted and ready to land.May 17 2025, 1:27 PM

kib marked 4 inline comments as done.May 17 2025, 5:44 PM

Closed by commit rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2) (authored by kib). · Explain WhyMon, May 19, 6:08 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG31760ee65ae3: libthr: add stable user interface for sigfastblock(2).

kib added a commit: rG1393f9a36b9c: pthread_signals_block_np(3): document.

Revision Contents
Changeset List

Path

Size

include/

2 lines

lib/

libthr/

2 lines

thread/

19 lines

Diff 155681

include/pthread_np.h

Loading...

lib/libthr/pthread.map

Loading...

lib/libthr/thread/thr_sig.c

Loading...