Page MenuHomeFreeBSD

sh: Avoid referencing uninitialized memory in alias
ClosedPublic

Authored by jrm on May 15 2025, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 7:00 AM
Unknown Object (File)
Wed, Nov 26, 10:37 PM
Unknown Object (File)
Wed, Nov 26, 10:32 PM
Unknown Object (File)
Tue, Nov 25, 6:39 AM
Unknown Object (File)
Sat, Nov 22, 8:57 PM
Unknown Object (File)
Fri, Nov 21, 3:34 PM
Unknown Object (File)
Fri, Nov 21, 8:20 AM
Unknown Object (File)
Sat, Nov 15, 2:42 PM
Subscribers

Details

Summary

If run as
alias ''
uninitialized memory could be referenced.

This is based on a fix from NetBSD. For more information, refer to the
commit log in
https://github.com/NetBSD/src/commit/10cfed82c282ff96a5a8818a9ce9b0e7444d418d

Obtained from: NetBSD (kre)
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.May 15 2025, 3:13 PM

Heh,

$ /bin/sh
$ alias '' ==
$ alias
Bus error (core dumped)
$ 
This revision is now accepted and ready to land.May 15 2025, 3:40 PM
emaste requested changes to this revision.May 15 2025, 3:45 PM
emaste added inline comments.
bin/sh/alias.c
208

n is by definition an empty string, so the message would be alias: : not found which is confusing

This revision now requires changes to proceed.May 15 2025, 3:45 PM
This revision is now accepted and ready to land.May 16 2025, 1:57 PM