Page MenuHomeFreeBSD
Differential D50320

cxgbetool.8: Fix Minor mechanical issues
ClosedPublic
Actions

Authored by ziaee on May 13 2025, 12:44 AM.
Tags
None
Referenced Files
F120584998: D50320.diff
Thu, Jun 19, 8:57 AM
Unknown Object (File)
Wed, Jun 18, 5:46 PM
Unknown Object (File)
Wed, Jun 18, 4:42 PM
Unknown Object (File)
Tue, Jun 17, 1:55 AM
Unknown Object (File)
Mon, Jun 9, 5:00 AM
Unknown Object (File)
Thu, Jun 5, 10:34 AM
Unknown Object (File)
Wed, May 28, 11:50 AM
Unknown Object (File)
Tue, May 27, 9:37 PM
View All 9 Files
Subscribers
imp

Details

Reviewers
jhb
carlavilla
mhorne
Group Reviewers
manpages
Commits
rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues
Summary

+ Tag SPDX
+ Macros should not appear in titles, write a hopefully better title
+ Nm needs to be on it's own line in SYNOPSIS, fold it so this page

does not appear in unrelated search results (test case `apropos fw`)

+ Remove Ns's that do nothing and generate linter errors
+ Move list initializers to where they render, correcting linter errors

Unresolved:
This page produces an error when rendered due to the table. I don't know
how to fix that yet, but I'm interested in learning!

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee created this revision.May 13 2025, 12:44 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 13 2025, 12:44 AM
ziaee requested review of this revision.May 13 2025, 12:44 AM
Harbormaster completed remote builds in B64117: Diff 155363.May 13 2025, 12:44 AM
ziaee retitled this revision from cxgbetool.8: Fix some mechanical issues to cxgbetool.8: Fix Minor mechanical issues.May 13 2025, 1:23 AM
mhorne accepted this revision.May 13 2025, 2:03 PM
mhorne added inline comments.
usr.sbin/cxgbetool/cxgbetool.8
40

Right?

706–708

Or the correct/appropriate wrapping.

This revision is now accepted and ready to land.May 13 2025, 2:03 PM
mhorne added inline comments.May 13 2025, 2:15 PM
usr.sbin/cxgbetool/cxgbetool.8
40

Right?

Wrong, apparently.

https://english.stackexchange.com/questions/315198/does-ethernet-need-to-be-capitalised

Closed by commit rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues (authored by ziaee). · Explain WhyMay 19 2025, 2:58 AM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues.
ziaee added a comment.May 19 2025, 3:01 AM

Thanks so much for being thorough and looking into these for me. I think we're improving the quality.

Revision Contents
Changeset List

PathSize
usr.sbin/
cxgbetool/
177 lines

Diff 155671

View Options

usr.sbin/cxgbetool/cxgbetool.8

Loading...