Page MenuHomeFreeBSD
Differential D5032

Fix spurious interrupts' issue on Armada38x
Needs ReviewPublic
Actions

Authored by bsz_semihalf.com on Jan 22 2016, 10:44 AM.
Tags
Referenced Files
Unknown Object (File)
Feb 23 2024, 10:46 PM
Unknown Object (File)
Jan 16 2024, 3:04 PM
Unknown Object (File)
Dec 22 2023, 9:35 PM
Unknown Object (File)
Nov 26 2023, 10:02 AM
Unknown Object (File)
Nov 13 2023, 1:37 PM
Unknown Object (File)
Oct 25 2023, 9:59 AM
Unknown Object (File)
Oct 3 2023, 2:18 AM
Unknown Object (File)
Jun 17 2023, 11:53 AM
View All 30 Files
Subscribers
andrew
mmel
zbb

Details

Reviewers
imp
• ian
Summary

Armada38X was affected with bug, causing multiple spurious interrupts to occur.
Solution required modification of DTS file - UART device's interrupts should be
triggered with edge instead of level.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bsz_semihalf.com updated this revision to Diff 12592.Jan 22 2016, 10:44 AM
bsz_semihalf.com retitled this revision from to Fix spurious interrupts' issue on Armada38x.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited the test plan for this revision. (Show Details)
bsz_semihalf.com added reviewers: • ian, imp.
bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
bsz_semihalf.com added a project: ARM.
bsz_semihalf.com added a subscriber: zbb.
Herald added a subscriber: andrew. · View Herald TranscriptJan 22 2016, 10:44 AM
mmel added a subscriber: mmel.Jan 22 2016, 2:44 PM

I have same problem with Tegra UART (it's also ns8250 based) , not yet identified. Are you sure that this is really bug in Armada38X chipset or we have bug in UART driver?

bsz_semihalf.com added a comment.Jan 26 2016, 11:48 AM
In D5032#106855, @meloun-miracle-cz wrote:

I have same problem with Tegra UART (it's also ns8250 based) , not yet identified. Are you sure that this is really bug in Armada38X chipset or we have bug in UART driver?

I'm not sure, but I found no other solution, even though I spent quite a lot of time investigating that. There are other platforms in tree (like rk3188) that use the same UART driver (with GIC, which sets default trigger to level) and don't seem to be affected, so I assume it is specific to A38X.

Does changing interrupt trigger makes any difference in your case?

mmel added a comment.Feb 12 2016, 5:32 AM

I hope that r295557 fixes spurious interrupt issues on all ns8250 based UARTs. Can you test it also on Armada 38x?

Revision Contents
Changeset List

PathSize
sys/
boot/
fdt/
dts/
arm/
4 lines

Diff 12592

View Options

sys/boot/fdt/dts/arm/armada-38x.dtsi

Loading...