Differential D50022

sound: Retire volch
ClosedPublic
Actions

Authored by christos on Apr 25 2025, 5:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 13, 2:21 AM

	Unknown Object (File)
	Tue, Sep 23, 3:16 PM

	Unknown Object (File)
	Mon, Sep 22, 1:22 PM

	Unknown Object (File)
	Fri, Sep 19, 4:03 AM

	Unknown Object (File)
	Fri, Sep 19, 12:28 AM

	Unknown Object (File)
	Wed, Sep 17, 12:58 PM

	Unknown Object (File)
	Wed, Sep 17, 9:28 AM

	Unknown Object (File)
	Wed, Sep 17, 6:20 AM

View All 64 Files

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGd0e6b4305f47: sound: Retire volch
rG578cbd03f7a5: sound: Retire volch

Summary

volch is a variable used internally in dsp_ioctl_channel() which
corresponds to either priv->rdch or priv->wrch. As a result, priv->volch
is also a pointer to one of those two channels, but is also not used
anywhere outside dsp_ioctl_channel(). Since the operation of figuring
out which channel we want to operate on inside dsp_ioctl_channel() is
cheap enough, retire volch to avoid unnecessary complexity and
confusion.

While here, rename "volch" to just "ch".

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Apr 25 2025, 5:26 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2025, 5:26 PM

christos requested review of this revision.Apr 25 2025, 5:26 PM

Harbormaster completed remote builds in B63727: Diff 154289.Apr 25 2025, 5:26 PM

Rebase on top of main

Harbormaster completed remote builds in B63744: Diff 154311.Apr 25 2025, 10:04 PM

markj added inline comments.Apr 26 2025, 3:15 PM

sys/dev/sound/pcm/dsp.c
577–578	Delete this comment too? It's not adding anything anymore.
699	Can't you just pass NULL here?

Address Mark's comments.

Harbormaster completed remote builds in B63749: Diff 154322.Apr 26 2025, 4:29 PM

markj accepted this revision.Apr 27 2025, 1:47 PM

This revision is now accepted and ready to land.Apr 27 2025, 1:47 PM

Closed by commit rG578cbd03f7a5: sound: Retire volch (authored by christos). · Explain WhyApr 29 2025, 2:01 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG578cbd03f7a5: sound: Retire volch.

christos added a commit: rGd0e6b4305f47: sound: Retire volch.May 2 2025, 10:47 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

61 lines

Diff 154472

sys/dev/sound/pcm/dsp.c

Loading...