Page MenuHomeFreeBSD

vm_object: use iterator in populate()
ClosedPublic

Authored by dougm on Apr 21 2025, 3:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:32 AM
Unknown Object (File)
Mon, Sep 29, 1:44 PM
Unknown Object (File)
Mon, Sep 22, 1:27 AM
Unknown Object (File)
Sun, Sep 21, 8:04 AM
Unknown Object (File)
Sat, Sep 20, 5:21 AM
Unknown Object (File)
Fri, Sep 19, 5:29 PM
Unknown Object (File)
Thu, Sep 18, 8:06 PM
Unknown Object (File)
Sep 15 2025, 7:50 AM
Subscribers

Details

Summary

Use an iterator instead of tailq pointers in vm_object_populate().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Apr 21 2025, 3:23 AM
dougm created this revision.
sys/vm/vm_object.c
2156

I can't use VM_RADIX_FOREACH because when page[start] is NULL, the loop should end but VM_RADIX_FORALL would just start with the first page > start.

I can't use VM_RADIX_FORALL because the original code can skip gaps of null pages, and FORALL cannot.

sys/vm/vm_object.c
2156

Perhaps add this text to the commit message, if not as a comment into the code.

dougm added a reviewer: alc.

Use the same iterator for grabbing and for unbusying. Use VM_RADIX_FORALL with an upper bound.

sys/vm/vm_object.c
2155–2156
This revision is now accepted and ready to land.Apr 24 2025, 11:37 PM
This revision was automatically updated to reflect the committed changes.