Page MenuHomeFreeBSD

arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic

Authored by andrew on Mar 28 2025, 5:16 PM.
Tags
None
Referenced Files
F151933872: D49559.id.diff
Sat, Apr 11, 3:02 PM
Unknown Object (File)
Fri, Apr 10, 6:02 AM
Unknown Object (File)
Fri, Apr 10, 12:24 AM
Unknown Object (File)
Tue, Apr 7, 9:53 AM
Unknown Object (File)
Mon, Apr 6, 2:44 AM
Unknown Object (File)
Fri, Mar 20, 10:24 PM
Unknown Object (File)
Mar 2 2026, 10:27 PM
Unknown Object (File)
Feb 28 2026, 5:14 AM

Details

Reviewers
manu
Group Reviewers
arm64
Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63184
Build 60068: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com added inline comments.
sys/arm64/arm64/busdma_bounce.c
105

Why is DMAMAP_COHERENT being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new #define below so this doesn't seem useful as you've got a halfway done job.

364–368

Since both of these are now single-line, I would remove the brackets while you're at it.