arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic
Actions

Authored by andrew on Mar 28 2025, 5:16 PM.

Tags

None

Referenced Files

	F160285179: D49559.id152802.diff
	Mon, Jun 22, 10:48 PM

	F160199506: D49559.diff
	Mon, Jun 22, 2:55 AM

	Unknown Object (File)
	Fri, Jun 19, 5:46 AM

	Unknown Object (File)
	Tue, Jun 16, 9:53 AM

	Unknown Object (File)
	Wed, Jun 10, 5:01 AM

	Unknown Object (File)
	Thu, Jun 4, 6:40 PM

	Unknown Object (File)
	May 15 2026, 4:39 AM

	Unknown Object (File)
	May 14 2026, 6:44 PM

Subscribers

Details

Reviewers

manu

Group Reviewers

arm64

Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63184
Build 60068: arc lint + arc unit

andrew requested review of this revision.Mar 28 2025, 5:16 PM

ehem_freebsd_m5p.com added inline comments.

sys/arm64/arm64/busdma_bounce.c
105	Why is `DMAMAP_COHERENT` being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new `#define` below so this doesn't seem useful as you've got a halfway done job.
364–368	Since both of these are now single-line, I would remove the brackets while you're at it.