arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic
Actions

Authored by andrew on Mar 28 2025, 5:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 8, 4:08 PM

	Unknown Object (File)
	Mon, Aug 3, 2:33 AM

	Unknown Object (File)
	Sat, Aug 1, 6:22 AM

	Unknown Object (File)
	Fri, Jul 31, 5:11 AM

	Unknown Object (File)
	Thu, Jul 30, 12:31 PM

	Unknown Object (File)
	Thu, Jul 30, 9:31 AM

	Unknown Object (File)
	Wed, Jul 29, 11:08 AM

	Unknown Object (File)
	Sat, Jul 25, 12:31 PM

Subscribers

Details

Reviewers

manu

Group Reviewers

arm64

Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63184
Build 60068: arc lint + arc unit

andrew requested review of this revision.Mar 28 2025, 5:16 PM

ehem_freebsd_m5p.com added inline comments.

sys/arm64/arm64/busdma_bounce.c
105	Why is `DMAMAP_COHERENT` being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new `#define` below so this doesn't seem useful as you've got a halfway done job.
364–368	Since both of these are now single-line, I would remove the brackets while you're at it.