arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic
Actions

Authored by andrew on Mar 28 2025, 5:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 26, 2:17 PM

	Unknown Object (File)
	Fri, Sep 26, 7:27 AM

	Unknown Object (File)
	Wed, Sep 24, 2:48 AM

	Unknown Object (File)
	Thu, Sep 18, 7:28 PM

	Unknown Object (File)
	Thu, Sep 18, 5:44 AM

	Unknown Object (File)
	Sep 15 2025, 8:26 AM

	Unknown Object (File)
	Aug 29 2025, 1:21 PM

	Unknown Object (File)
	Aug 26 2025, 4:48 AM

Subscribers

Details

Reviewers

manu

Group Reviewers

arm64

Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63184
Build 60068: arc lint + arc unit

andrew requested review of this revision.Mar 28 2025, 5:16 PM

ehem_freebsd_m5p.com added inline comments.

sys/arm64/arm64/busdma_bounce.c
105	Why is `DMAMAP_COHERENT` being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new `#define` below so this doesn't seem useful as you've got a halfway done job.
364–368	Since both of these are now single-line, I would remove the brackets while you're at it.