ptrace: Do not pass a negative resid to proc_rwmem()
ClosedPublic
Actions

Authored by markj on Mar 23 2025, 10:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 23, 11:47 PM

	Unknown Object (File)
	Fri, Apr 18, 11:04 PM

	Unknown Object (File)
	Wed, Apr 16, 7:48 PM

	Unknown Object (File)
	Tue, Apr 15, 8:28 AM

	Unknown Object (File)
	Sun, Apr 13, 5:40 AM

	Unknown Object (File)
	Sat, Apr 12, 10:25 AM

	Unknown Object (File)
	Fri, Apr 11, 12:01 PM

	Unknown Object (File)
	Fri, Apr 4, 9:27 PM

View All 15 Files

Subscribers

imp

olce

Details

Reviewers

kib

Commits

rG74a0b8908483: ptrace: Do not pass a negative resid to proc_rwmem()
rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem()

Summary

uiomove() asserts against this.

proc_iop() already asserts this, but maybe it should be a runtime check.

While here, avoid truncting uio_resid in proc_rwmem().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 23 2025, 10:36 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 23 2025, 10:36 PM

markj requested review of this revision.Mar 23 2025, 10:36 PM

Harbormaster completed remote builds in B63086: Diff 152578.Mar 23 2025, 10:36 PM

kib accepted this revision.Mar 24 2025, 1:32 AM

This revision is now accepted and ready to land.Mar 24 2025, 1:32 AM

Closed by commit rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem() (authored by markj). · Explain WhyMon, Mar 31, 9:06 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem().

markj added a commit: rG74a0b8908483: ptrace: Do not pass a negative resid to proc_rwmem().Tue, Apr 15, 2:26 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

sys_process.c

6 lines

Diff 152888

View Options

ptrace: Do not pass a negative resid to proc_rwmem()ClosedPublicActions