ptrace: Do not pass a negative resid to proc_rwmem()
ClosedPublic
Actions

Authored by markj on Mar 23 2025, 10:36 PM.

Tags

None

Referenced Files

	F133065145: D49479.diff
	Wed, Oct 22, 3:33 PM

	Unknown Object (File)
	Wed, Oct 22, 6:50 AM

	Unknown Object (File)
	Tue, Oct 21, 10:50 AM

	Unknown Object (File)
	Sat, Oct 18, 3:53 AM

	Unknown Object (File)
	Tue, Oct 14, 6:59 AM

	Unknown Object (File)
	Sat, Oct 11, 4:26 AM

	Unknown Object (File)
	Fri, Oct 3, 5:28 PM

	Unknown Object (File)
	Fri, Oct 3, 5:12 PM

View All 47 Files

Subscribers

imp

olce

Details

Reviewers

kib

Commits

rG74a0b8908483: ptrace: Do not pass a negative resid to proc_rwmem()
rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem()

Summary

uiomove() asserts against this.

proc_iop() already asserts this, but maybe it should be a runtime check.

While here, avoid truncting uio_resid in proc_rwmem().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 23 2025, 10:36 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 23 2025, 10:36 PM

markj requested review of this revision.Mar 23 2025, 10:36 PM

Harbormaster completed remote builds in B63086: Diff 152578.Mar 23 2025, 10:36 PM

kib accepted this revision.Mar 24 2025, 1:32 AM

This revision is now accepted and ready to land.Mar 24 2025, 1:32 AM

Closed by commit rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem() (authored by markj). · Explain WhyMar 31 2025, 9:06 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1a80a157cbe8: ptrace: Do not pass a negative resid to proc_rwmem().

markj added a commit: rG74a0b8908483: ptrace: Do not pass a negative resid to proc_rwmem().Apr 15 2025, 2:26 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

sys_process.c

6 lines

Diff 152888

View Options

ptrace: Do not pass a negative resid to proc_rwmem()ClosedPublicActions