Differential D49364

sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()
ClosedPublic
Actions

Authored by glebius on Mar 14 2025, 6:06 PM.

Details

Reviewers

markj

Group Reviewers

network

Commits

rG67c1c4dfd1cc: sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()

Summary

The sbreserve() works only on protocol-independent parts of the sockbuf,
but sbrelease() also clears the generic sockbuf mbuf chain. Calling the
latter to undo changes done by the former is not correct. The new
function is the right thing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 14 2025, 6:06 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 14 2025, 6:06 PM

glebius requested review of this revision.Mar 14 2025, 6:06 PM

Harbormaster completed remote builds in B62923: Diff 152271.Mar 14 2025, 6:07 PM

glebius added a parent revision: D49363: sockbuf: remove sbflush_internal() and sbrelease_internal() shims.Mar 14 2025, 6:07 PM

The sbreserve() works only on protocol-independent parts of the sockbuf

Typo, soreserve().

This revision is now accepted and ready to land.Mar 17 2025, 7:28 AM

Closed by commit rG67c1c4dfd1cc: sockbuf: provide sbunreserve_locked() which is a complement to sbreserve() (authored by glebius). · Explain WhyMar 24 2025, 6:41 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG67c1c4dfd1cc: sockbuf: provide sbunreserve_locked() which is a complement to sbreserve().

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_sockbuf.c

19 lines

Diff 152609

View Options

sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()ClosedPublicActions