Page MenuHomeFreeBSD

dtrace/arm64: Fix dtrace_gethrtime()
ClosedPublic

Authored by markj on Mar 5 2025, 11:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 6:44 AM
Unknown Object (File)
Mon, Sep 29, 3:39 PM
Unknown Object (File)
Sep 15 2025, 12:55 AM
Unknown Object (File)
Sep 8 2025, 4:29 PM
Unknown Object (File)
Aug 29 2025, 10:43 AM
Unknown Object (File)
Aug 21 2025, 10:00 AM
Unknown Object (File)
Aug 19 2025, 12:43 PM
Unknown Object (File)
Aug 13 2025, 6:23 PM
Subscribers

Details

Summary

This routine returns a monotonic count of the number of nanoseconds elapsed
since the previous call. On arm64 it uses the generic system timer. The
implementation multiplies the counter value by 10**9 then divides by the counter
frequency, but this multiplication can overflow. This can result in trace
records with non-monotonic timestamps, which breaks libdtrace's temporal
ordering algorithm.

An easy fix is to reverse the order of operations, since the counter frequency
will in general be smaller than 10**9. (In fact, it's mandated to be 1Ghz in
ARMv9, which makes life simple.) However, this can give a fair bit of error.
Adopt the calculation used on amd64, with tweaks to handle frequencies as low as
1MHz: the ARM generic timer documentation suggests that ARMv8 timers are
typically in the 1MHz-50MHz range, which is true on arm64 systems that I have
access to.

Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable