Page MenuHomeFreeBSD

linuxkpi: Add `show_fdinfo()` to `struct file_operations`
AcceptedPublic

Authored by dumbbell on Feb 19 2025, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 10:17 PM
Unknown Object (File)
Mon, Mar 17, 2:43 AM
Unknown Object (File)
Sun, Mar 9, 9:34 AM
Unknown Object (File)
Mar 4 2025, 10:14 AM
Unknown Object (File)
Mar 2 2025, 2:44 PM
Unknown Object (File)
Feb 28 2025, 3:48 PM
Unknown Object (File)
Feb 26 2025, 4:10 PM
Unknown Object (File)
Feb 26 2025, 4:00 PM
Subscribers

Details

Reviewers
bz
Group Reviewers
linuxkpi
Summary

We never call this field but it allows to compile drivers without modifications.

This is used by the DRM drivers for some time, but another change part of the update to Linux 6.8 led to compile them with CONFIG_PROC_FS. This connected code that uses this struct field.

This is part of the update of DRM drivers to Linux 6.8.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell edited the summary of this revision. (Show Details)
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/fs.h
157

No need for variable names in declarations (remove m and f) also to stay consistent with the rest of the file.

This likely warrants another __FreeBSD_version bump (so maybe do that when all changes are going in together).

Address style-related comment from bz

This revision is now accepted and ready to land.Tue, Apr 1, 11:01 PM