Remove documentation for variables nai, server_nai, and eappsk.
Support for these variables was removed upstream several years ago.
Details
Details
PR 284126
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is great!
The summary field should contain the commit log message, like a report on what's going on for people unfamiliar with the subject:
wpa_supplicant.conf.5: Remove removed variables 2005-09-25 - wpa_supplicant v0.4.5 removed "server_nai" 2008-02-22 - wpa_supplicant v0.6.3 removed "eappsk" and "nai" PR: 284126 MFC after: 3 days Reported by: J.R. Oldroyd <fbsd@opal.com> Differential Revision: https://reviews.freebsd.org/D49010
The first line should be the file that's changing, followed by a brief summary for people searching though the commit logs.
The PR trailer updates the bug thread and provides the cross-reference.
Since this change is non breaking and applies to past versions of FreeBSD, we should use an MFC trailer to declare intent to backport this patch to stable.
The original reporter was J.R. Oldroyd, so we should give them credit.
Finally, the differential revision trailer provides a link to this discussion.
@carlavilla and/or @mhorne , may I commit this (with a bumped date)?
Comment Actions
Can you please confirm the author info you want on the commit -- I see Felix Johnson <fjohnson@felix-johnson.com> and Felix Johnson <felix.the.red@gmail.com> in the commit history now.
Comment Actions
Oops! I forgot about this. Felix has been afk for a few weeks, but he switched his new reviews to his domain lately, I'll use that.
Comment Actions
I wish I had a list of open revisions that I've approved, and another list of open revisions I've commented on. That would really help.
Warner sent me something once but I have 0.1m emails and can't come up with the right regex to find it.