Page MenuHomeFreeBSD
Differential D48766

physmem: Move the ram0 device earlier in the boot
AcceptedPublic
Actions

Authored by andrew on Fri, Jan 31, 3:12 PM.

Details

Reviewers
kevans
mhorne
imp
Summary

If the ram driver is unable to reserve a memory range it will panic
with no real information why. Move this driver earlier in the boot so
any devices that cause the conflict will fail to attach.

This should make it easier to debug why the conflict exists.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62171
Build 59055: arc lint + arc unit

Event Timeline

andrew created this revision.Fri, Jan 31, 3:12 PM
Herald added a subscriber: olce. · View Herald TranscriptFri, Jan 31, 3:12 PM
andrew requested review of this revision.Fri, Jan 31, 3:12 PM
Harbormaster completed remote builds in B62171: Diff 150262.Fri, Jan 31, 3:12 PM
imp accepted this revision.Fri, Jan 31, 3:16 PM
This revision is now accepted and ready to land.Fri, Jan 31, 3:16 PM
kevans accepted this revision.Fri, Jan 31, 3:30 PM
mhorne added a comment.Fri, Jan 31, 4:59 PM

Yes, this is smarter.

I kind of regret adding this thing. Although it is conceptually helpful/correct, its positive practical impact has so far been zero, while it has created several headaches.

mhorne accepted this revision.Fri, Jan 31, 4:59 PM
kevans added a comment.EditedFri, Jan 31, 6:04 PM
In D48766#1112402, @mhorne wrote:

Yes, this is smarter.

I kind of regret adding this thing. Although it is conceptually helpful/correct, its positive practical impact has so far been zero, while it has created several headaches.

Meh, it'll turn its life around- more failure to attach because of it rather than panicking will trend it back towards positive practical impact and fewer headaches, and it's a pretty small diff to get there.

Revision Contents
Changeset List

PathSize
sys/
kern/
3 lines

Diff 150262

View Options

sys/kern/subr_physmem.c

Loading...