Page MenuHomeFreeBSD
Differential D48589

bnxt_en: Retrieve maximum of 128 APP TLVs
AcceptedPublic
Actions

Authored by zlei on Wed, Jan 22, 12:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 10:38 PM
Unknown Object (File)
Mon, Jan 27, 3:49 PM
Unknown Object (File)
Mon, Jan 27, 11:58 AM
Unknown Object (File)
Sun, Jan 26, 11:57 AM
Unknown Object (File)
Wed, Jan 22, 1:49 PM
Unknown Object (File)
Wed, Jan 22, 12:32 PM
Unknown Object (File)
Wed, Jan 22, 12:21 PM
Unknown Object (File)
Wed, Jan 22, 12:21 PM
Subscribers
None

Details

Reviewers
chandrakanth.patil_broadcom.com
sumit.saxena_broadcom.com
shurd
imp
markj
Summary

It appears the maximum number of APP TLVs supported by the hardware is 128 according to D45005. Well user reports that the number may exceed the limit, causing out of bound write to on-stack allocated variable app[128] and the kernel panics.

Limit to 128 while retrieving APP TLVs.

PR: 284073
Fixes: 35b53f8c989f bnxt_en: Add PFC, ETS & App TLVs protocols support
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Wed, Jan 22, 12:09 PM
zlei created this revision.
zlei edited the summary of this revision. (Show Details)Wed, Jan 22, 12:20 PM
markj accepted this revision.Thu, Jan 23, 2:20 PM

It would really be better to pass the maximum number of entries as a parameter, instead of hard-coding 128 in several places.

This revision is now accepted and ready to land.Thu, Jan 23, 2:20 PM
zlei added a comment.Thu, Jan 23, 2:53 PM
In D48589#1108835, @markj wrote:

It would really be better to pass the maximum number of entries as a parameter, instead of hard-coding 128 in several places.

Good point.

Revision Contents
Changeset List

PathSize
sys/
dev/
bnxt/
bnxt_en/
4 lines

Diff 149703

View Options

sys/dev/bnxt/bnxt_en/bnxt_dcb.c

Loading...