Differential D48577

arm64: fix ID_AA64ISAR2_WFxT_IMPL value
ClosedPublic
Actions

Authored by harry.moulton_arm.com on Jan 21 2025, 3:19 PM.

Tags

None

Referenced Files

	F170646543: D48577.id.diff
	Sat, Sep 5, 7:21 PM

	F170599668: D48577.id.diff
	Sat, Sep 5, 2:19 PM

	F170581177: D48577.id149666.diff
	Sat, Sep 5, 12:24 PM

	Unknown Object (File)
	Fri, Sep 4, 2:25 AM

	Unknown Object (File)
	Thu, Sep 3, 11:49 AM

	Unknown Object (File)
	Thu, Sep 3, 10:18 AM

	Unknown Object (File)
	Wed, Sep 2, 2:15 PM

	Unknown Object (File)
	Wed, Sep 2, 9:50 AM

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Commits

rG4e3831c66d00: arm64: fix ID_AA64ISAR2_WFxT_IMPL value

Summary

Bits 3:0 of ID_AA64ISAR2_EL1 are reserved for FEAT_WFxT in ARMv8.7, with
bit 1 used to determine whether the feature is supported. The macro,
ID_AA64ISAR2_WFxT_IMPL can be used to check if this bit is set, however
it is currently incorrectly set to check bit 0. This has now been
corrected.

Sponsored by: Arm Ltd
Signed-off-by: Harry Moulton <harry.moulton@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

harry.moulton_arm.com created this revision.Jan 21 2025, 3:19 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 21 2025, 3:19 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

harry.moulton_arm.com requested review of this revision.Jan 21 2025, 3:19 PM

Harbormaster completed remote builds in B61865: Diff 149666.Jan 21 2025, 3:20 PM

harry.moulton_arm.com added child revisions: D48578: arm64: add HWCAP for FEAT_WFxT, D48579: arm64: add inline functions for FEAT_WFxT instructions, D48580: arm64: use FEAT_WFxT for DELAY() when available.Jan 21 2025, 3:23 PM

andrew accepted this revision.Jan 21 2025, 3:44 PM

This revision is now accepted and ready to land.Jan 21 2025, 3:44 PM

Closed by commit rG4e3831c66d00: arm64: fix ID_AA64ISAR2_WFxT_IMPL value (authored by harry.moulton_arm.com, committed by andrew). · Explain WhyJan 23 2025, 5:27 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG4e3831c66d00: arm64: fix ID_AA64ISAR2_WFxT_IMPL value.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

2 lines

Diff 149803

sys/arm64/include/armreg.h

Loading...