Get it implemented for mbuf based XDR. Right now all existing consumers
use only mbuf based XDR. However, future changes will require appending
data stored in an mbuf to memory buffer based XDR.
Details
Details
- Reviewers
rmacklem - Group Reviewers
network - Commits
- rG66612e673652: xdr: provide x_putmbuf method for kernel XDR
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 61820 Build 58704: arc lint + arc unit
Event Timeline
| sys/rpc/auth_unix.c | ||
|---|---|---|
| 254 | Above you return the value returned by xdr_putmbuf(). There are several more examples of this below. | |
| sys/rpc/auth_unix.c | ||
|---|---|---|
| 254 | The xdr_putmbuf() on the mbuf based xdr always succeeds. Just like xdrmbuf_append() was a void. I think in all cases where I omit returning return of xdr_putmbuf() is where we know that it is mbuf based xdr. But I will recheck this. Thanks! Maybe bringing to the same style of return (xdr_putmbuf()), or asserting that that return value is TRUE is better than current version. What would you prefer? | |
| sys/rpc/auth_unix.c | ||
|---|---|---|
| 254 | Either sounds fine to me. | |
Comment Actions
Consistently either return return value of the method, or annotate with void.
Note that void annotated places all explicitly operate on mbuf-based xdr,
that was created few lines above. For this type of xdr, the method never
fails.