Details
- Reviewers
salvadore pauamma_gundo.com freebsd_ny-central.org - Group Reviewers
status - Commits
- R9:87532deaa63a: Website - Status: Add Common Lisp report
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 61661 Build 58545: arc lint + arc unit
Event Timeline
@carlavilla, in the future, could you please not commit my work without discussing it with me first?
My apologies, I committed it because a message send to the status mailing list.
If you're ok I'll revert it in two hours. Let me know it.
Rather than have a messy commit log, it's best (from my perspective) to leave things as they are now.
TBC, I was waiting because @salvadore is a blocking reviewer. Also, I needed to update the commit log before pushing.
I may have caused that with my email to Lorenzo on the status mailing list. I suggested things are ready to move towards commit after reviews but didn't mean to override any established processes.
Apologies if I caused confusion - will do my best to improve clarity in future mails.
It's not such a big deal in these particular cases, but as a matter of principle, I felt it was worth mentioning that pushing another committer's review without first discussing it with the committer can lead to problems. Is the commit really ready? Is the commit log ready? (Without using something like git arc Phabricator can mess with the commit log.) Are there any other commits that must be committed first?
In any case, I appreciate the responses. Let's put this to rest now.