Page MenuHomeFreeBSD

Add pidfile support to ggated(8)
AbandonedPublic

Authored by ngie on Jan 8 2016, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 5:54 AM
Unknown Object (File)
Mon, Oct 28, 8:49 AM
Unknown Object (File)
Sat, Oct 26, 6:33 PM
Unknown Object (File)
Sat, Oct 26, 6:33 PM
Unknown Object (File)
Sat, Oct 26, 6:12 PM
Unknown Object (File)
Sat, Oct 26, 1:37 AM
Unknown Object (File)
Fri, Oct 25, 4:22 PM
Unknown Object (File)
Fri, Oct 25, 12:55 AM

Details

Reviewers
pjd
Group Reviewers
manpages
Summary

Add pidfile support to ggated(8)

The tests will manipulate the system daemon today, which can cause undesired
service interruption when run.

This change allows the geom_gate tests to be run with an arbitrary ggated(8)
daemon / geom_gate(4) device pairing.

  • Sort #includes
  • Use a more common idiom for parsing options with getopt(3)

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

Test Plan

I've been using this version with the tests in
^/user/ngie/more-tests2/tests/sys/geom/class/geom_gate for some time
successfully

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2009
Build 2017: arc lint + arc unit

Event Timeline

ngie retitled this revision from to Add pidfile support to ggated(8).
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie added a reviewer: pjd.
ngie added subscribers: benno, brueffer.
bjk added inline comments.
sbin/ggate/ggated/ggated.8
94

Spurious leading .El, I think.

ngie marked an inline comment as done.Jan 9 2016, 1:17 AM
ngie added inline comments.
sbin/ggate/ggated/ggated.8
94

mandoc -Tlint agrees -- thanks !

ngie marked an inline comment as done.
ngie edited edge metadata.

Remove spurious .El in ggated(8)

Reported by: bjk

The man page also needs to update .Dd, sorry I missed that before.
(Still too busy to look at the code itself.)

In D4836#104404, @bjk wrote:

The man page also needs to update .Dd, sorry I missed that before.
(Still too busy to look at the code itself.)

Done.