Tweak ppoll() to include 1003.1-2024 visibility
ClosedPublic
Actions

Authored by kevans on Thu, Dec 12, 4:11 AM.

Details

Reviewers

emaste
imp
kib

Commits

rG74ecdf86d8d2: Tweak ppoll() to include 1003.1-2024 visibility, take two
rG212d7f439aa3: Tweak ppoll() to include 1003.1-2024 visibility

Summary

Note in the manpage that the 2024 edition finally added ppoll(), and
also add the appropriate declarations for the correct versions of
_POSIX_C_SOURCE.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans requested review of this revision.Thu, Dec 12, 4:11 AM

kevans created this revision.

Harbormaster completed remote builds in B61097: Diff 147840.Thu, Dec 12, 4:11 AM

imp accepted this revision.Thu, Dec 12, 4:18 AM

imp added inline comments.

include/ssp/poll.h
45	I thought a L suff

This revision is now accepted and ready to land.Thu, Dec 12, 4:18 AM

Ignore my comment. I thought I'd deleted it

kib added inline comments.Thu, Dec 12, 4:58 AM

sys/sys/poll.h
99	Isn't check for __BSD_VISIBLE redundant?

imp added inline comments.Thu, Dec 12, 5:06 AM

sys/sys/poll.h
99	It is... but we do this in a lot of places. Should we fix those?

kib added inline comments.Thu, Dec 12, 5:13 AM

sys/sys/poll.h
99	Usually we avoid the redundancy. So fixing them is worth the efforts, IMO.

imp added inline comments.Thu, Dec 12, 5:15 AM

sys/sys/poll.h
99	Most that are wrong are recent. One is old. Several are right... we should fix

kevans added inline comments.Thu, Dec 12, 5:38 AM

sys/sys/poll.h
99	Ok, will axe that half off of all these pre-commit

imp added inline comments.Thu, Dec 12, 5:45 AM

sys/sys/poll.h
99	Ill submit a cleanup once universe is done

As an aside, it's also the case that

The
.Fn poll
and
.Fn ppoll
functions conform to
.St -p1003.1-2024 .

Mentioning the older standard is useful in terms of suggesting how portable it is to other operating systems or older FreeBSD versions, but that should probably be discussed explicitly in HISTORY instead. fork did get that treatment (in D47588) because POSIX 2024 did change the language so that we actually conform.

I'm not suggesting making this change for the ppoll update; it is something we'll want to discuss and have a plan for before any holistic review and update of POSIX 2024 references in man pages.

Closed by commit rG212d7f439aa3: Tweak ppoll() to include 1003.1-2024 visibility (authored by kevans). · Explain WhySat, Dec 14, 4:16 AM

This revision was automatically updated to reflect the committed changes.

kevans marked 6 inline comments as done.

kevans added a commit: rG212d7f439aa3: Tweak ppoll() to include 1003.1-2024 visibility.

kevans added a reverting change: rGda5aed38d80a: Revert "Tweak ppoll() to include 1003.1-2024 visibility".Sat, Dec 14, 7:06 AM

kevans added a commit: rG74ecdf86d8d2: Tweak ppoll() to include 1003.1-2024 visibility, take two.Sun, Dec 15, 4:41 AM