Allwinner DTS update

[manu_bidouilliste.com]

Summary

This diff :

• update Allwinner drivers to use the "compatible" string from vendor DTS
• Convert some drivers to EARLY_DRIVER_MODULE so they attach at the right time
• Convert A10 and A20 to FDT_PLATFORM
• Add two function named allwinner_soc_type() and allwinner_soc_family() which return the SoC type and family based on fdt platform init
• Add a generic A10 kernel config file
• A20 now use generic_timer and ARM_INTRNG
• Add two new custom dts file for Olimex boards (we need custom one because one doesn't have chosen or aliases node for the serial and the serial needs our busy-detect property)
• Update our custom DTS file for a10 and a20 to use the same compatible property names as the vendor ones.
• Update vendor DTS file for allwinner

Test Plan

Apply patch.
Build kernel.
Boot kernel on ARM board.

[imp]

How far are we now from Linux dts files?

[manu_bidouilliste.com]

In D4792#101671, @imp wrote:

How far are we now from Linux dts files?

For the Olimex board, linux dts file are used but we still need custom one for the clock control module (the linux one doesn't have it declared) and for the chosen/aliases node for serial.
I don't have a Bananapi or Cubieboard but I think that they will need the same custom ones on top of the Linux DTS.

[manu_bidouilliste.com]

Set the phy-mode of the gmac to rgmii-bpi so 1000bps link works better

[andrew]

First pass

sys/arm/allwinner/a10_clk.c

113

This should be indented 4 spaces

sys/arm/allwinner/a10_gpio.c

382–383

You can use ofw_bus_find_compatible here.

503

4 spaces

sys/arm/allwinner/a10_machdep.c

62 ↗

(On Diff #12178)

Missing newline

122 ↗

(On Diff #12178)

This should be:

u_int
alwinner_soc_type(void)
{

127 ↗

(On Diff #12178)

And here

sys/arm/allwinner/a20/a20_cpu_cfg.c

121

4 spaces

sys/arm/allwinner/a20/a20_machdep.c

63 ↗

(On Diff #12178)

missing newline

123–131 ↗

(On Diff #12178)

These should be in a common file to allow A10 and A20 to be built together

sys/arm/allwinner/aintc.c

168

4 spaces

sys/arm/allwinner/allwinner_machdep.h

1

Why as this file a copy of an existing file?

5

Was it?

29–30

This should be unneeded as you will have already included it before including this file

30

Should be

#define<TAB>_ALLWINNER_MACHDEP_H_

sys/arm/allwinner/timer.c

140

What's this needed for?

354

4 spaces

sys/arm/conf/A10

2

You should update the CUBIEBOARD config file to include this one & only add the options it that don't appear here

sys/boot/fdt/dts/arm/olimex-a20-som-evb.dts

1

Why is this file a copy?

29

I don't think this is needed anymore

[andrew]

sys/arm/allwinner/a10_gpio.c

382–383

I meant ofw_bus_search_compatible

[manu_bidouilliste.com]

Next diff correct style(9) and all the comment above.

sys/arm/allwinner/allwinner_machdep.h

1

No, I don t know if git or phab thinks that.

5

No just a bad copy/paste error

sys/arm/allwinner/timer.c

140

Left over or early code, thanks for notice this.

sys/arm/conf/A10

2

CUBIEBOARD should be removed and user should use A10 directly, I'm just waiting for some user to confirm that A10 work on this board as I don't have it myself. But for now every person that had it don't anymore.

sys/boot/fdt/dts/arm/olimex-a20-som-evb.dts

1

No, I just copy the licence, I don't know if it git or phab that thinks that.

29

Next diff will take care of that.

[manu_bidouilliste.com]

Fix style(9) issues.
Update to latest DTS.
Merge machdep files so A10 and A20 could be compiled together.
Use ofw_bus_search_compatible where appropriate.

[manu_bidouilliste.com]

FDT_PLATFORM was commited.
This new diff:

• Update drivers to parse upstream compatible props
• Update our custom DTS to use the same compatible props
• Convert some driver to EARLY driver because of the order of the upstream DTS.
• Add a generic A10 kernel config
• Make A20 use generic_timer
• Update the upstream DTS.

[manu_bidouilliste.com]

Last diff also include conversion for cubieboard2 to upstream DTS.
Confirmed by jmcneill.

[andrew]

sys/arm/allwinner/a10_ehci.c

101–102

The newline here was correct

sys/arm/allwinner/a10_gpio.c

503

Why _LAST?

[manu_bidouilliste.com]

Fix style and remove _LAST

[manu_bidouilliste.com]

sys/arm/allwinner/a10_gpio.c

503

This is not needed anymore, I put it to do test when converting to EARLY_DRIVER

[andrew]

With EARLY_DRIVER_MODULE we normally add BUS_PASS_ORDER_MIDDLE to the pass to allow other drivers to hook in before it if needed.

sys/arm/allwinner/a10_gpio.c

503

We normally use _MIDDLE to allow other drivers to attach earlier if needed

[manu_bidouilliste.com]

Update diff since the DTS from Linux have now been imported.

[andrew]

sys/arm/allwinner/allwinner_machdep.c

66

Extra whitespace change

sys/arm/allwinner/timer.c

148–155

This could be:

if (!ofw_bus_is_compatible(...))
  return (ENXIO);

soc_family = allwinner_soc_family();
if (soc_family != ...)
  return (ENXIO);

sys/arm/conf/A10

53

Is this needed? It's better to get this from ubldr.

[manu_bidouilliste.com]

sys/arm/conf/A10

53

Totally unneeded, it was just to reflect what the comment is saying.

[andrew]

sys/arm/conf/A10

53

Ok, you should remove it and the comment.

[manu_bidouilliste.com]

sys/arm/conf/A10

53

Ok, should I also remove the one from A20 too while I'm here ?

[andrew]

sys/arm/conf/A10

53

Yes, if it also uses ubldr.

[manu_bidouilliste.com]

Update diff based on andrew comments.