Page MenuHomeFreeBSD
Differential D47921

riscv: support Allwinner D1 GPIO controller
AbandonedPublic
Actions

Authored by mhorne on Dec 4 2024, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 4:53 AM
Unknown Object (File)
Fri, Dec 27, 4:22 AM
Unknown Object (File)
Thu, Dec 26, 12:41 PM
Unknown Object (File)
Dec 12 2024, 6:55 PM
Unknown Object (File)
Dec 11 2024, 10:13 AM
Unknown Object (File)
Dec 9 2024, 9:05 AM
Unknown Object (File)
Dec 5 2024, 11:25 AM
Subscribers
imp
riscv

Details

Reviewers
manu
br
julien.cassette_gmail.com
andrew
Summary

Enable the driver.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60960
Build 57844: arc lint + arc unit

Event Timeline

mhorne created this revision.Dec 4 2024, 6:30 PM
Herald added a reviewer: andrew. · View Herald TranscriptDec 4 2024, 6:30 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Dec 4 2024, 6:30 PM
Harbormaster completed remote builds in B60960: Diff 147499.Dec 4 2024, 6:30 PM
mhorne added a comment.Dec 4 2024, 6:33 PM

Rebased from D35593, but this is basically unchanged.

sys/arm/allwinner/aw_gpio.c
427

I believe this could use the macro. Magic numbers are widespread within this driver.

502–503

I'm still really unsure about this part of the change. It seems the mask could have stayed inside the parenthesis?

julien.cassette_gmail.com added inline comments.Dec 4 2024, 8:19 PM
sys/arm/allwinner/aw_gpio.c
502–503

I guess it was clearer for me: offset and idx are two parts of the same value, offset is just bits 4..0 and idx is just bits 31..5

mhorne added inline comments.Dec 10 2024, 8:51 PM
sys/arm/allwinner/aw_gpio.c
502–503

ACK. With this explanation I am happy with it.

mhorne abandoned this revision.Dec 10 2024, 9:33 PM

Committed in 71924545585, but I listed the original review.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
man4.arm/
5 lines
sys/
arm/
allwinner/
4 lines
136 lines
riscv/
allwinner/
129 lines
3 lines
conf/
1 line
1 line

Diff 147499

View Options

share/man/man4/man4.arm/aw_gpio.4

Loading...
View Options

sys/arm/allwinner/allwinner_pinctrl.h

Loading...
View Options

sys/arm/allwinner/aw_gpio.c

Loading...
View Options

sys/riscv/allwinner/d1_padconf.c

Loading...
View Options

sys/riscv/allwinner/files.allwinner

Loading...
View Options

sys/riscv/conf/GENERIC

Loading...
View Options

sys/riscv/conf/std.allwinner

Loading...