Differential D47697

pf: Set cleared time when zeroing stats for table addresses
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Nov 21 2024, 8:39 PM.

Tags

None

Referenced Files

	F151137245: D47697.id146811.diff
	Mon, Apr 6, 8:27 AM

	F151058634: D47697.diff
	Sun, Apr 5, 5:14 PM

	Unknown Object (File)
	Sat, Apr 4, 6:18 AM

	Unknown Object (File)
	Sat, Apr 4, 5:27 AM

	Unknown Object (File)
	Sat, Mar 21, 7:49 PM

	Unknown Object (File)
	Sun, Mar 15, 1:08 PM

	Unknown Object (File)
	Sat, Mar 14, 11:44 PM

	Unknown Object (File)
	Mar 7 2026, 4:23 AM

Subscribers

Details

Reviewers

Commits

rG6c7cef47bdd0: pf: Set cleared time when zeroing stats for table addresses
rG1d673cc1fd82: pf: Set cleared time when zeroing stats for table addresses
rG1a5dc6ee62b3: pf: Set cleared time when zeroing stats for table addresses

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Nov 21 2024, 8:39 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptNov 21 2024, 8:39 PM

vegeta_tuxpowered.net requested review of this revision.Nov 21 2024, 8:39 PM

There's no need for additional variable, time is used only once.

emaste added a subscriber: emaste.Nov 21 2024, 10:47 PM

Approved.

I'd love to see https://cgit.freebsd.org/src/tree/tests/sys/netpfil/pf/table.sh#n119 extended to also check for this.

This revision is now accepted and ready to land.Nov 22 2024, 12:27 PM

Closed by commit rG1a5dc6ee62b3: pf: Set cleared time when zeroing stats for table addresses (authored by vegeta_tuxpowered.net). · Explain WhyNov 28 2024, 9:41 AM

This revision was automatically updated to reflect the committed changes.

vegeta_tuxpowered.net added a commit: rG1a5dc6ee62b3: pf: Set cleared time when zeroing stats for table addresses.

kp added a commit: rG1d673cc1fd82: pf: Set cleared time when zeroing stats for table addresses.Dec 27 2024, 6:05 PM

kp added a commit: rG6c7cef47bdd0: pf: Set cleared time when zeroing stats for table addresses.

leon_darkk.net.ru mentioned this in D48242: pf (tests): Set cleared time when zeroing stats for table addresses.Dec 29 2024, 11:19 AM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

2 lines

Diff 147104

sys/netpfil/pf/pf_table.c

Loading...