Page MenuHomeFreeBSD
Differential D47437

arm64: Fix comparing ID register fields
ClosedPublic
Actions

Authored by andrew on Nov 4 2024, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 8:54 PM
Unknown Object (File)
Thu, Oct 16, 4:37 AM
Unknown Object (File)
Tue, Sep 30, 3:26 AM
Unknown Object (File)
Sun, Sep 28, 7:38 AM
Unknown Object (File)
Sat, Sep 27, 6:45 PM
Unknown Object (File)
Thu, Sep 25, 11:55 PM
Unknown Object (File)
Mon, Sep 22, 2:38 PM
Unknown Object (File)
Mon, Sep 22, 7:53 AM
View All 44 Files
Subscribers
emaste

Details

Reviewers
imp
manu
Group Reviewers
arm64
Commits
rGce284dded5d5: arm64: Fix comparing ID register fields
Summary

The logic in update_special_reg_field was reversed. Fix by swapping the
order of the arguments.

PR: 282505
Fixes: f1fb1d5c9017 ("arm64: Support more ID register field types")
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60381
Build 57265: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 4 2024, 5:11 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 4 2024, 5:11 PM
Herald added a subscriber: emaste. · View Herald Transcript
andrew requested review of this revision.Nov 4 2024, 5:11 PM
Harbormaster completed remote builds in B60381: Diff 145994.Nov 4 2024, 5:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2024, 5:48 PM
Closed by commit rGce284dded5d5: arm64: Fix comparing ID register fields (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGce284dded5d5: arm64: Fix comparing ID register fields.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
6 lines

Diff 145994

View Options

sys/arm64/arm64/identcpu.c

Loading...