Page MenuHomeFreeBSD
Differential D47337

e1000: Improve igb SFP support
ClosedPublic
Actions

Authored by kbowling on Wed, Oct 30, 9:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 7:42 AM
Unknown Object (File)
Thu, Nov 7, 6:01 AM
Unknown Object (File)
Thu, Nov 7, 6:00 AM
Unknown Object (File)
Tue, Nov 5, 8:59 AM
Unknown Object (File)
Mon, Nov 4, 5:07 PM
Unknown Object (File)
Mon, Nov 4, 1:49 AM
Subscribers
franco_opnsense.org
imp

Details

Reviewers
markj
emaste
Group Reviewers
Intel Networking
Restricted Owners Package(Owns No Changed Paths)
Commits
rGcf6a8711e437: e1000: Improve igb(4) SFP support
rGc66d2795bdb5: e1000: Improve igb(4) SFP support
rG15853a5fc954: e1000: Improve igb(4) SFP support
Summary
  • Adds support for SFPs that are not correctly coded as an SFP transceiver. i.e. Coherent-Finisar FCLF8522P2BTL.
  • Configures multi-rate SFPs i.e. Coherent-Finisar FCLF8522P2BTL as SGMII so they can do 10/100/1000 auto-negotiation.
  • Adds support for 100BaseLX SGMII transceivers.
  • Some code cleanup and additional debugging.
Test Plan

Tested on various managed and unmanaged access switches and back to back.

Customer testing ongoing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.Wed, Oct 30, 9:14 AM
Owners added a reviewer: Restricted Owners Package.Wed, Oct 30, 9:14 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 30, 9:14 AM
kbowling requested review of this revision.Wed, Oct 30, 9:14 AM
markj accepted this revision.Wed, Oct 30, 1:06 PM
emaste added inline comments.Wed, Oct 30, 1:48 PM
sys/dev/e1000/e1000_82575.c
1750

This comment is a bit puzzling - we've already read the SFP's EEPROM, right? So we can assume there is a SFP module plugged in.

I was originally wondering if the "else" case could arise from a card with an empty SFP cage, but I think it can only be a module is present but is not SFP/SFF?

How does a SFP DAC cable show up?

emaste added inline comments.Wed, Oct 30, 2:03 PM
sys/dev/e1000/e1000_82575.c
1750

Oh, presumably this is the point in the summary -- "SFPs that are not correctly coded as an SFP transceiver." What is the impact of not setting module_plugged then?

kbowling added inline comments.Wed, Oct 30, 5:32 PM
sys/dev/e1000/e1000_82575.c
1750

It's covered by Table 5.1 in the SFP MSA -- for whatever reason in this case we get back 0 "Unknown" and that is causing the customer issue.

Because the module type (Table 5.3) is read without regard to the transceiver type before and after my changes I would tend to agree we basically know we have an SFP or SFF at this point but the general error case of landing on e1000_media_type_unknown should be the same with my changes if we didn't get a transceiver type back.

A DAC should show up as an SFP, they contain an EEPROM as well.

module_plugged is a write only variable here and in Linux and DPDK. Maybe it was intended to optimize the PHY layer, there is a little bit of chicken and egg going on here where the MAC comes up first and makes assumptions about the PHY including powering it up.

kbowling retitled this revision from e1000: Fix and improve SFP support to e1000: Improve igb SFP support .Wed, Oct 30, 5:39 PM
emaste accepted this revision.Wed, Oct 30, 5:50 PM

Seems reasonable to me. Will be good to cast a wide testing net.

franco_opnsense.org added a subscriber: franco_opnsense.org.Tue, Nov 5, 7:01 AM
franco_opnsense.org added inline comments.
sys/dev/e1000/e1000_82575.c
1704

add break here too?

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Nov 7, 6:16 AM
Closed by commit rG15853a5fc954: e1000: Improve igb(4) SFP support (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG15853a5fc954: e1000: Improve igb(4) SFP support.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGc66d2795bdb5: e1000: Improve igb(4) SFP support.Thu, Nov 21, 5:52 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGcf6a8711e437: e1000: Improve igb(4) SFP support.

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/
40 lines

Diff 146127

View Options

sys/dev/e1000/e1000_82575.c

Loading...