pf: Fix timestamps in source node export to userspace
Needs ReviewPublic
Actions

Authored by vegeta_tuxpowered.net on Mon, Oct 28, 10:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 11:03 PM

	Unknown Object (File)
	Sat, Nov 2, 11:31 AM

	Unknown Object (File)
	Sat, Nov 2, 9:11 AM

	Unknown Object (File)
	Fri, Nov 1, 6:29 PM

	Unknown Object (File)
	Fri, Nov 1, 6:24 PM

Subscribers

Details

Reviewers

Summary

Pfctl expects SN's creation and expiry to not be absolute timestamps but time deltas.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Mon, Oct 28, 10:16 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptMon, Oct 28, 10:16 PM

vegeta_tuxpowered.net requested review of this revision.Mon, Oct 28, 10:16 PM

Good catch, although I think we need to fix nlattr_add_pf_threshold() as well.

It might be slightly better to save time_uptime to a separate variable first, because we don't want it to change in between calculations.

I'm going to make you commit this one yourself, once it's ready.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_nl.c

7 lines

Diff 145566

View Options

pf: Fix timestamps in source node export to userspaceNeeds ReviewPublicActions