This was lost during the converting to netlink.
Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink
MFC after: 1 week
Details
Details
Watching the output of ndp -A1 . Compare the output with rtsock based implementation.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.sbin/ndp/ndp_netlink.c | ||
|---|---|---|
| 342 | I'm not sure but it seems snl_finalize_msg() and snl_send_message() do not fail. | |
Comment Actions
It's not as straightforward for '-A' as it'd be for other options, but we should look into writing a test case for this too.
Known bugs are an obvious candidate for test cases after all.
I think that something like timeout 5 ndp -A 2 is a good basis to start from. (I.e. ensure we have two copies of the expected neighbour entry).
| usr.sbin/ndp/ndp_netlink.c | ||
|---|---|---|
| 342 | snl_finalize_msg() will return NULL if there's been an error on the snl_writer previously, and snl_send_message() communicates with the kernel, which can pretty much always fail. So I do think we still need these checks (even if they're pretty unlikely to fail). | |
| 389 | This results in an empty line between each iteration. On the whole that's probably a good thing, but I don't know if that was also the case before the switch to netlink or not. | |
Comment Actions
I'll try to make one test case for that.
I think that something like timeout 5 ndp -A 2 is a good basis to start from. (I.e. ensure we have two copies of the expected neighbour entry).
Sounds good.
| usr.sbin/ndp/ndp_netlink.c | ||
|---|---|---|
| 389 | The original rtsock based implementation has this extra empty line. | |