Page MenuHomeFreeBSD
Differential D47202

Increase number of regions in physical RAM which can be tracked
AcceptedPublic
Actions

Authored by bcran on Oct 19 2024, 7:27 PM.
Tags
None
Referenced Files
F106177191: D47202.diff
Thu, Dec 26, 4:14 PM
Unknown Object (File)
Mon, Dec 23, 7:19 AM
Unknown Object (File)
Fri, Dec 13, 6:07 PM
Unknown Object (File)
Mon, Dec 9, 4:10 AM
Unknown Object (File)
Tue, Dec 3, 11:06 AM
Unknown Object (File)
Nov 19 2024, 8:08 AM
Unknown Object (File)
Nov 7 2024, 2:57 AM
Unknown Object (File)
Nov 7 2024, 2:56 AM
View All 22 Files
Subscribers
olce

Details

Reviewers
imp
manu
andrew
Summary

The ASRock Rack ALTRAD8UD-1L2T AMI AptioV UEFI firmware has 63
areas of memory with RuntimeServicesData or RuntimeServicesCode.




Increase the values of MAX_HWCNT and MAX_EXCNT to 256 to avoid

overflowing the arrays (resulting in the boot hanging) when booting on

this system or any others which have very fragmented memory maps.
Test Plan
Verified that after this change FreeBSD -CURRENT boots on my ALTRAD8UD-1L2T

system. Also verified that by allocating 40 alternating runtime and boot 

areas on my ADLINK Ampere Altra Dev Platform with EDK2 UEFI firmware that

FreeBSD also ends up hanging.
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Passed
 
Unit 
No Test Coverage
 
Build Status 
Buildable 60100
Build 56984: arc lint + arc unit
 
Event Timeline
bcran created this revision.Oct 19 2024, 7:27 PM
Herald added a subscriber: olce.  ·  View Herald TranscriptOct 19 2024, 7:27 PM
bcran requested review of this revision.Oct 19 2024, 7:27 PM
Harbormaster completed remote builds in B60100: Diff 145174.Oct 19 2024, 7:27 PM
imp accepted this revision.Oct 19 2024, 7:37 PM
The increased memory is trivial. Why not 128 if there's one with 63 now?
This revision is now accepted and ready to land.Oct 19 2024, 7:37 PM
bcran updated this revision to Diff 145180.Oct 19 2024, 7:51 PM
Increase array size to 256, as suggested by the developer who root caused the problem.
This revision now requires review to proceed.Oct 19 2024, 7:51 PM
Harbormaster completed remote builds in B60102: Diff 145180.Oct 19 2024, 7:51 PM
bcran updated this revision to Diff 145181.Oct 19 2024, 7:53 PM
Actually update the value to 256.
Harbormaster completed remote builds in B60103: Diff 145181.Oct 19 2024, 7:53 PM
bcran added a comment.Oct 19 2024, 7:54 PM


In D47202#1076166, @imp wrote:


The increased memory is trivial. Why not 128 if there's one with 63 now?





The PAE engineer who root caused the hang suggested 256 or 512, so I've updated the patch to 256.
bcran retitled this revision from Double number of regions in physical RAM which can be tracked to Increase number of regions in physical RAM which can be tracked.Oct 19 2024, 7:54 PM
bcran edited the summary of this revision. (Show Details)
imp accepted this revision.Oct 19 2024, 9:18 PM
All good. Do you need someone to push the change? Or do you still have a valid bit?
This revision is now accepted and ready to land.Oct 19 2024, 9:18 PM
bcran added a comment.Oct 19 2024, 9:28 PM


In D47202#1076215, @imp wrote:


All good. Do you need someone to push the change? Or do you still have a valid bit?





Thanks. I need someone to push the change, since my bit was taken for safekeeping.
Revision Contents
Changeset List
PathSize
sys/
kern/
4 lines
Diff 145174
View Options
sys/kern/subr_physmem.c
Loading...