Page MenuHomeFreeBSD
Differential D4718

Staticize several variables that are used exclusively in bsnmpd/main.c and bsnmpd/trap.c
ClosedPublic
Actions

Authored by ngie on Dec 28 2015, 1:05 AM.
Tags
None
Referenced Files
F105707446: D4718.diff
Thu, Dec 19, 12:15 PM
Unknown Object (File)
Tue, Dec 10, 1:36 AM
Unknown Object (File)
Wed, Nov 20, 5:54 AM
Unknown Object (File)
Nov 15 2024, 12:12 PM
Unknown Object (File)
Nov 13 2024, 11:27 AM
Unknown Object (File)
Nov 13 2024, 12:34 AM
Unknown Object (File)
Nov 1 2024, 10:28 PM
Unknown Object (File)
Sep 19 2024, 10:06 PM
View All 60 Files
Subscribers
araujo
bapt
imp

Details

Reviewers
araujo
harti
Summary

This fixes several -Wmissing-variable-declaration warnings with
clang reported by Jenkins here:

MFC after: 1 week
Reported by: Jenkins
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ngie updated this revision to Diff 11729.Dec 28 2015, 1:05 AM
ngie retitled this revision from to Staticize several variables that are used exclusively in bsnmpd/main.c.
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie added a reviewer: harti.
ngie set the repository for this revision to rS FreeBSD src repository - subversion.
ngie added subscribers: araujo, bapt.
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2015, 1:05 AM
ngie updated this revision to Diff 11730.Dec 28 2015, 1:12 AM
ngie retitled this revision from Staticize several variables that are used exclusively in bsnmpd/main.c to Staticize several variables that are used exclusively in bsnmpd/main.c and bsnmpd/trap.c.
ngie updated this object.
ngie removed rS FreeBSD src repository - subversion as the repository for this revision.

Add trap.c diff as well

araujo accepted this revision.Dec 28 2015, 1:22 AM
araujo added a reviewer: araujo.

LGTM, I have a plan to update snmpd, I have contacted harti@ but seems he is not too active nowadays.

Best,

This revision is now accepted and ready to land.Dec 28 2015, 1:22 AM
ngie added a comment.Dec 28 2015, 1:52 AM
In D4718#99868, @araujo wrote:

LGTM, I have a plan to update snmpd, I have contacted harti@ but seems he is not too active nowadays.

Best,

Thanks for the review :)!

I wanted to fix the warnings so Jenkins would be happy and so NO_WERROR could be turned off in the associated Makefile(s). $work has some enhancements and potential fixes coming down the pike soon for bsnmpd, and I just want to make sure bugs don't sneak in by accident :).

ngie closed this revision.Dec 28 2015, 1:52 AM

Revision Contents
Changeset List

PathSize
contrib/
bsnmp/
snmpd/
16 lines

Diff 11729

View Options

contrib/bsnmp/snmpd/main.c

Loading...