trap.c
ClosedPublic
Actions

Authored by ngie on Dec 28 2015, 1:05 AM.

Details

Reviewers

araujo
harti

Summary

This fixes several -Wmissing-variable-declaration warnings with
clang reported by Jenkins here:

MFC after: 1 week
Reported by: Jenkins
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ngie updated this revision to Diff 11729.Dec 28 2015, 1:05 AM

ngie retitled this revision from to Staticize several variables that are used exclusively in bsnmpd/main.c.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: harti.

ngie set the repository for this revision to rS FreeBSD src repository - subversion.

ngie added subscribers: araujo, bapt.

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2015, 1:05 AM

Add trap.c diff as well

LGTM, I have a plan to update snmpd, I have contacted harti@ but seems he is not too active nowadays.

Best,

This revision is now accepted and ready to land.Dec 28 2015, 1:22 AM

In D4718#99868, @araujo wrote:

LGTM, I have a plan to update snmpd, I have contacted harti@ but seems he is not too active nowadays.

Best,

Thanks for the review :)!

I wanted to fix the warnings so Jenkins would be happy and so NO_WERROR could be turned off in the associated Makefile(s). $work has some enhancements and potential fixes coming down the pike soon for bsnmpd, and I just want to make sure bugs don't sneak in by accident :).

ngie closed this revision.Dec 28 2015, 1:52 AM