Paths

Table of Contentst

Differential D47175

pf tests: Lower chances of false positives for mbuf:inet6_in_mbuf_len
ClosedPublic
Actions

Authored by igoro on Oct 18 2024, 2:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 2:38 AM

	Unknown Object (File)
	Thu, Dec 26, 12:27 PM

	Unknown Object (File)
	Thu, Dec 26, 6:16 AM

	Unknown Object (File)
	Wed, Dec 25, 9:26 AM

	Unknown Object (File)
	Dec 9 2024, 5:10 AM

	Unknown Object (File)
	Dec 4 2024, 2:28 AM

	Unknown Object (File)
	Dec 1 2024, 4:32 AM

	Unknown Object (File)
	Nov 9 2024, 7:59 PM

View All 12 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

kp
markj

Commits

rG8829d4cb09d3: pf tests: Lower chances of false positives for mbuf:inet6_in_mbuf_len

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

igoro created this revision.Oct 18 2024, 2:02 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptOct 18 2024, 2:02 PM

igoro requested review of this revision.Oct 18 2024, 2:02 PM

Harbormaster completed remote builds in B60065: Diff 145107.Oct 18 2024, 2:02 PM

This is the outcome of my analysis of the following CI test failure: https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/25598/testReport/junit/sys.netpfil.pf/mbuf/inet6_in_mbuf_len/.
An extra 2001:db8::1 → 2001:db8::2 ICMPv6 Neighbor Advertisement 2001:db8::1 (sol) packet can appear. If it's sent after the net.dummymbuf.hits value is compared then it does not impact the results, but it may happen before.

I would have guessed it'd be MLD packets, but neighbour unreachability detection could also be causing this.

Approved.

This revision is now accepted and ready to land.Oct 18 2024, 2:18 PM

Closed by commit rG8829d4cb09d3: pf tests: Lower chances of false positives for mbuf:inet6_in_mbuf_len (authored by igoro). · Explain WhyOct 18 2024, 4:26 PM

This revision was automatically updated to reflect the committed changes.

igoro added a commit: rG8829d4cb09d3: pf tests: Lower chances of false positives for mbuf:inet6_in_mbuf_len.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

5 lines

Diff 145111

tests/sys/netpfil/pf/mbuf.sh

Loading...