ping: tests: Cleanup IPOption()s
ClosedPublic
Actions

Authored by jlduran on Oct 16 2024, 5:16 PM.

Tags

None

Referenced Files

	F166148971: D47160.diff
	Tue, Aug 11, 11:39 PM

	Unknown Object (File)
	Sat, Jul 25, 6:53 PM

	Unknown Object (File)
	Mon, Jul 20, 4:26 PM

	Unknown Object (File)
	Mon, Jul 20, 5:49 AM

	Unknown Object (File)
	Mon, Jul 20, 12:53 AM

	Unknown Object (File)
	Sat, Jul 18, 4:13 AM

	Unknown Object (File)
	Jun 21 2026, 7:28 AM

	Unknown Object (File)
	Jun 7 2026, 7:10 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste
kp

Group Reviewers

network

Commits

rG797884a5d990: ping: tests: Cleanup IPOption()s
rG2e29bf7a2ae6: ping: tests: Cleanup IPOption()s

Summary

Scapy now only accepts known options with IPOption(), so our unknown
option must be passed raw.

While here, prefer the named options for EOL and NOP.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Oct 16 2024, 5:16 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 16 2024, 5:16 PM

jlduran requested review of this revision.Oct 16 2024, 5:16 PM

Harbormaster completed remote builds in B60048: Diff 145003.Oct 16 2024, 5:16 PM

jlduran added a reviewer: network.Oct 16 2024, 5:29 PM

kp accepted this revision as: kp.Oct 22 2024, 4:55 PM

This revision is now accepted and ready to land.Oct 22 2024, 4:55 PM

emaste accepted this revision.Oct 22 2024, 5:09 PM

Closed by commit rG2e29bf7a2ae6: ping: tests: Cleanup IPOption()s (authored by jlduran). · Explain WhyNov 5 2024, 2:50 AM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG2e29bf7a2ae6: ping: tests: Cleanup IPOption()s.

jlduran added a commit: rG797884a5d990: ping: tests: Cleanup IPOption()s.Nov 14 2024, 3:26 AM

Revision Contents
Changeset List

Path

Size

sbin/

ping/

tests/

test_ping.py

8 lines

Diff 146037

View Options

sbin/ping/tests/test_ping.py

ping: tests: Cleanup IPOption()sClosedPublicActions