Page MenuHomeFreeBSD
Differential D47155

device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
ClosedPublic
Actions

Authored by jhb on Oct 16 2024, 3:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 9:51 PM
Unknown Object (File)
Wed, Dec 4, 12:58 PM
Unknown Object (File)
Tue, Dec 3, 10:08 PM
Unknown Object (File)
Tue, Dec 3, 5:40 PM
Unknown Object (File)
Sun, Dec 1, 7:19 AM
Unknown Object (File)
Nov 9 2024, 11:06 PM
Unknown Object (File)
Nov 6 2024, 4:32 PM
Unknown Object (File)
Nov 6 2024, 4:22 PM
View All 19 Files
Subscribers
olce

Details

Reviewers
imp
Commits
rG304744faa13b: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
rGc7ec1fadb52d: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails
Summary

This gives the parent bus driver the opportunity to cleanup any
allocated resources, etc. left behind by a failed attach attempt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60042
Build 56926: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 16 2024, 3:27 PM
Herald added a subscriber: olce. · View Herald TranscriptOct 16 2024, 3:27 PM
jhb requested review of this revision.Oct 16 2024, 3:27 PM
Harbormaster completed remote builds in B60042: Diff 144995.Oct 16 2024, 3:27 PM
jhb added a parent revision: D47154: device_delete_child: Update comments.Oct 16 2024, 3:27 PM
jhb added a child revision: D47156: bus_generic_detach: Remove redundant check.
imp accepted this revision.Oct 16 2024, 3:34 PM

So long as the parent doesn't call the child's detach, this is great. I'm pretty sure this is the case, but we need to make sure there's no double freeing introduced

This revision is now accepted and ready to land.Oct 16 2024, 3:34 PM
jhb added a comment.Oct 16 2024, 6:06 PM

I don't think the parent can interfere here as DEVICE_ATTACH calls the child method directly without giving the parent driver a chance to interpose.

Closed by commit rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails (authored by jhb). · Explain WhyOct 16 2024, 6:11 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG42078dfb0f72: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.
jhb added a commit: rGc7ec1fadb52d: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.Sun, Dec 1, 4:57 AM
jhb added a commit: rG304744faa13b: device_attach: Invoke BUS_CHILD_DETACHED if an attach routine fails.

Revision Contents
Changeset List

PathSize
sys/
kern/
1 line

Diff 144995

View Options

sys/kern/subr_bus.c

Loading...