Page MenuHomeFreeBSD

vm_object: Add wrapper for bumping generation counter
AbandonedPublic

Authored by bnovkov on Oct 10 2024, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:44 AM
Unknown Object (File)
Sun, Dec 15, 10:24 AM
Unknown Object (File)
Nov 19 2024, 6:28 PM
Unknown Object (File)
Nov 6 2024, 6:04 AM
Unknown Object (File)
Nov 6 2024, 3:27 AM
Unknown Object (File)
Nov 4 2024, 7:01 AM
Unknown Object (File)
Oct 31 2024, 9:49 AM
Unknown Object (File)
Oct 24 2024, 5:08 PM
Subscribers

Details

Reviewers
markj
alc
kib

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59893
Build 56778: arc lint + arc unit

Event Timeline

sys/vm/vm_object.c
2344

Where is this used? I can't find it in the rest of the patch stack.

Why is it ever necessary to bump the counter by more than 1? Consumers (should) only care about whether it changed relative to a previously loaded value, and not about the magnitude of the difference.

bnovkov added inline comments.
sys/vm/vm_object.c
2344

Where is this used? I can't find it in the rest of the patch stack.

It is used in the vm_radixdone's batch counterpart.

Why is it ever necessary to bump the counter by more than 1? Consumers (should) only care about whether it changed relative to a previously loaded value, and not about the magnitude of the difference.

I agree with you on this, but I eventually opted for replicating the behavior of calling vm_page_alloc in a loop, just to avoid inadvertently breaking something unrelated to this change.

However, seeing as you pretty much confirmed that this does not matter I'll go ahead and drop the review, thanks!