Page MenuHomeFreeBSD

shm_alloc(): cleanup
ClosedPublic

Authored by kib on Oct 8 2024, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 7:26 AM
Unknown Object (File)
Thu, Nov 7, 10:36 PM
Unknown Object (File)
Wed, Nov 6, 5:20 AM
Unknown Object (File)
Oct 28 2024, 8:37 PM
Unknown Object (File)
Oct 15 2024, 10:22 AM
Unknown Object (File)
Oct 11 2024, 11:28 AM
Unknown Object (File)
Oct 10 2024, 1:09 AM
Unknown Object (File)
Oct 9 2024, 11:50 AM
Subscribers

Details

Summary
Consistently use the shorter name 'obj' for the new object.
Set OBJ_POSIXSHM flag outside if, it is set on both pathes.

Suggested by:   alc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Oct 8 2024, 5:50 PM

I think that unlocked assignment to swp/phys_priv is fine,the field is never changed after the initialization. I would even set the flag lockless, since the object is not yet visible, but I think the consistency is useful there, e.g. for sanitizers.

sys/kern/uipc_shm.c
947–948

The assignment to shmfd->shm_object here isn't needed.

kib marked an inline comment as done.

Remove unneeded assignment.

This revision is now accepted and ready to land.Oct 9 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.