Page MenuHomeFreeBSD
Differential D47013

nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials
ClosedPublic
Actions

Authored by olce on Oct 8 2024, 1:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 3:49 PM
Unknown Object (File)
Mon, Jan 6, 8:16 AM
Unknown Object (File)
Thu, Jan 2, 7:30 AM
Unknown Object (File)
Dec 18 2024, 11:18 PM
Unknown Object (File)
Dec 16 2024, 6:54 PM
Unknown Object (File)
Dec 16 2024, 6:54 PM
Unknown Object (File)
Dec 13 2024, 8:45 PM
Unknown Object (File)
Dec 12 2024, 8:11 PM
View All 16 Files
Subscribers
emaste
imp

Details

Reviewers
rmacklem
Commits
rG46f0ef933d28: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials
rGd8b77cc05ab2: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials
rG84337218786b: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials
Summary

There is no technical reason to limit that to NGROUPS_MAX, which is off
by one and just our minimum maximum value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59844
Build 56729: arc lint + arc unit

Event Timeline

olce created this revision.Oct 8 2024, 1:47 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 1:47 PM
olce requested review of this revision.Oct 8 2024, 1:47 PM
Harbormaster completed remote builds in B59844: Diff 144488.Oct 8 2024, 1:47 PM
olce added a parent revision: D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.Oct 8 2024, 1:47 PM
olce added a child revision: D47014: mountd(8): parsecred(): Remove comment on non-existent bug.Oct 8 2024, 1:48 PM
olce mentioned this in D46920: mountd(8): parsecred(): Remove "duplicate compression".Oct 8 2024, 2:43 PM
rmacklem accepted this revision.Oct 9 2024, 2:29 AM

Looks fine to me, since ngroups_max can never
be set < NGROUPS_MAX.

This revision is now accepted and ready to land.Oct 9 2024, 2:29 AM
olce mentioned this in D46921: mountd(8): parsecred(): Groups limit: NGROUPS_MAX => NGROUPS_MAX + 1.Oct 14 2024, 3:11 PM
Closed by commit rG84337218786b: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials (authored by olce). · Explain WhyDec 16 2024, 2:46 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG84337218786b: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials.
olce added a commit: rGd8b77cc05ab2: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials.Thu, Jan 16, 6:09 PM
olce added a commit: rG46f0ef933d28: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials.Fri, Jan 17, 12:28 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 144488

View Options

sys/kern/vfs_mount.c

Loading...