Differential D47014

mountd(8): parsecred(): Remove comment on non-existent bug
ClosedPublic
Actions

Authored by olce on Oct 8 2024, 1:47 PM.

Tags

None

Referenced Files

	F111177972: D47014.id144489.diff
	Fri, Feb 28, 11:33 AM

	Unknown Object (File)
	Sat, Feb 22, 2:30 PM

	Unknown Object (File)
	Sat, Feb 8, 8:00 PM

	Unknown Object (File)
	Fri, Jan 31, 3:51 AM

	Unknown Object (File)
	Jan 17 2025, 3:02 AM

	Unknown Object (File)
	Jan 13 2025, 11:54 PM

	Unknown Object (File)
	Jan 13 2025, 1:52 AM

	Unknown Object (File)
	Jan 12 2025, 9:58 PM

View All 21 Files

Subscribers

Details

Reviewers

Commits

rG111c7322f71e: mountd(8): parsecred(): Remove comment on non-existent bug
rG42a885e6907c: mountd(8): parsecred(): Remove comment on non-existent bug
rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug

Summary

'name' can never be NULL, as it is equal to 'names' and 'namelist',
which was passed by do_cred() only if the actual parameter wasn't NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Oct 8 2024, 1:47 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 1:47 PM

olce requested review of this revision.Oct 8 2024, 1:47 PM

Harbormaster completed remote builds in B59845: Diff 144489.Oct 8 2024, 1:47 PM

olce added a parent revision: D47013: nmount(2), NFS: Accept 'ngroups_max + 1' groups in "export" credentials.Oct 8 2024, 1:48 PM

olce added a child revision: D47015: mountd(8): parsecred(): Re-order operations for clarity.

Looks ok to me.

This revision is now accepted and ready to land.Oct 16 2024, 3:30 PM

Closed by commit rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug (authored by olce). · Explain WhyDec 16 2024, 2:46 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG0b011b5cddb5: mountd(8): parsecred(): Remove comment on non-existent bug.

olce added a commit: rG42a885e6907c: mountd(8): parsecred(): Remove comment on non-existent bug.Jan 16 2025, 6:09 PM

olce added a commit: rG111c7322f71e: mountd(8): parsecred(): Remove comment on non-existent bug.Jan 17 2025, 12:28 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mountd/

1 line

Diff 148041

usr.sbin/mountd/mountd.c

Loading...