Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/libsys/membarrier.2 | ||
---|---|---|
81 |
Would it be possible to have all the cmds sorted alphabetically?
Only MEMBARRIER_CMD_SHARED references another cmd, but that one (MEMBARRIER_CMD_GLOBAL) will be presented earlier if cmds are sorted.
lib/libsys/membarrier.2 | ||
---|---|---|
63 | Missing final period (".") at the end of the paragraph | |
105 | Maybe .Fa cmd since cmd is an actual argument? |
Would it be possible to have all the cmds sorted alphabetically?
They're currently in order of their bit position, but they could be alphabetical instead. I'll take a look,
lib/libsys/membarrier.2 | ||
---|---|---|
105 | Yes and presumably a Dv to follow .Fa cmd |
Would it be possible to have all the cmds sorted alphabetically?
I decided not to do this, because they're in a somewhat logical order now. It would be odd to put MEMBARRIER_CMD_QUERY between other commands, it should be either first or last. Then there are a number of them that are paired, the CMD_REGISTER_foo and CMD_foo.